From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V5] ppc4xx: Add 405EP based PMC405DE board
Date: Wed, 22 Jul 2009 13:12:17 +0200 [thread overview]
Message-ID: <200907221312.17644.sr@denx.de> (raw)
In-Reply-To: <20090722110556.5A320832E416@gemini.denx.de>
On Wednesday 22 July 2009 13:05:56 Wolfgang Denk wrote:
> I don't understand what's so difficult about it; just indent by TABs:
>
> struct ppc4xx_config ppc4xx_config_val[] = {
> {
> "133",
> "CPU: 133 PLB: 133 OPB: 66 EBC: 44 PCI: 44/66",
> {
> 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> 0x00, 0x40, 0x12, 0x12, 0x42, 0x3e, 0x00, 0x00,
> }
> },
OK, now let's compare your version with ours:
> + { "133", "CPU: 133 PLB: 133 OPB: 66 EBC: 44 PCI: 44/66",
> + { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> + 0x00, 0x40, 0x12, 0x12, 0x42, 0x3e, 0x00, 0x00 } },
Your version is 10 lines long, ours is 5. That twice as long. I still prefer
our version and think this kind of personal freedom should be allowed.
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
next prev parent reply other threads:[~2009-07-22 11:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-21 10:22 [U-Boot] [PATCH V5] ppc4xx: Add 405EP based PMC405DE board Matthias Fuchs
2009-07-22 7:26 ` Wolfgang Denk
2009-07-22 7:36 ` Stefan Roese
2009-07-22 8:23 ` Matthias Fuchs
2009-07-22 8:29 ` Stefan Roese
2009-07-22 9:41 ` Wolfgang Denk
2009-07-22 9:47 ` Stefan Roese
2009-07-22 10:34 ` Wolfgang Denk
2009-07-22 10:57 ` Stefan Roese
2009-07-22 11:08 ` Wolfgang Denk
2009-07-22 11:22 ` Stefan Roese
2009-07-22 10:14 ` Matthias Fuchs
2009-07-22 11:05 ` Wolfgang Denk
2009-07-22 11:12 ` Stefan Roese [this message]
2009-07-22 11:15 ` Wolfgang Denk
2009-07-22 8:24 ` Matthias Fuchs
2009-07-22 8:36 ` Stefan Roese
2009-07-22 9:49 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907221312.17644.sr@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox