From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] Use do_div from div64.h for vsprintf
Date: Thu, 23 Jul 2009 10:23:44 +0200 [thread overview]
Message-ID: <200907231023.44375.sr@denx.de> (raw)
In-Reply-To: <1248277916-4623-1-git-send-email-dirk.behme@googlemail.com>
On Wednesday 22 July 2009 17:51:56 Dirk Behme wrote:
> Use do_div from div64.h for vsprintf in case of 64bit division.
> For 32bit division, do_div from div64.h can't be used as it
> needs a 64bit parameter.
>
> Signed-off-by: Dirk Behme <dirk.behme@googlemail.com>
> CC: Simon Kagstrom <simon.kagstrom@netinsight.net>
I just did some testing on the image size effect of this patch. All this is
done on Canyonlands (PPC4xx):
a) Without 64bit printf support, without this patch
b) With 64bit printf support, without this patch
c) With 64bit printf support, with this patch
Image-type Image-size
---------------------------
a 351028
b 352536
c 351400
So without this patch the 64bit printf support increases the image size by
5390 bytes and with this patch by "only" 984 bytes.
So ack from me for this patch:
Acked-by: Stefan Roese <sr@denx.de>
Thanks.
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
next prev parent reply other threads:[~2009-07-23 8:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-22 15:51 [U-Boot] [PATCH v2] Use do_div from div64.h for vsprintf Dirk Behme
2009-07-23 8:23 ` Stefan Roese [this message]
2009-07-26 22:10 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907231023.44375.sr@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox