From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] Add md5sum and sha1 commands...
Date: Sun, 26 Jul 2009 12:42:13 -0400 [thread overview]
Message-ID: <200907261242.14607.vapier@gentoo.org> (raw)
In-Reply-To: <200907252325.00174.rgetz@blackfin.uclinux.org>
On Saturday 25 July 2009 23:25:00 Robin Getz wrote:
> On Sat 25 Jul 2009 22:49, Mike Frysinger pondered:
> > On Saturday 25 July 2009 16:07:49 Robin Getz wrote:
> > > +#ifdef CONFIG_CMD_MD5SUM
> > > +U_BOOT_CMD(
> > > + md5sum, 3, 1, do_md5sum,
> > > + "compute MD5 message digest",
> > > + "address count"
> > > +);
> > > +#endif
> > > +
> > > +#ifdef CONFIG_CMD_SHA1
> > > +U_BOOT_CMD(
> > > + sha1, 3, 1, do_sha1,
> > > + "compute SHA1 message digest",
> > > + "address count"
> > > +);
> > > +#endif /* CONFIG_CMD_SHA1 */
> >
> > there's no need for these to be at the bottom of the file. move the
> > U_BOOT_CMD() into the releated #ifdef block.
>
> I'm just doing the same as all the other things in the same file (which
> doesn't mean it is correct). What is the preferred style?
ive been merging them to reduce #ifdef noise
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090726/4aa056bc/attachment.pgp
next prev parent reply other threads:[~2009-07-26 16:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-25 20:07 [U-Boot] Add md5sum and sha1 commands Robin Getz
2009-07-26 2:49 ` Mike Frysinger
2009-07-26 3:25 ` Robin Getz
2009-07-26 16:42 ` Mike Frysinger [this message]
2009-07-26 21:21 ` Wolfgang Denk
2009-07-27 4:07 ` [U-Boot] [PATCH] " Robin Getz
2009-08-11 17:57 ` Robin Getz
2009-08-11 19:21 ` Wolfgang Denk
2009-08-11 19:36 ` Robin Getz
2009-08-13 5:03 ` Mike Frysinger
2009-08-13 19:00 ` [U-Boot] " Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907261242.14607.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox