public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Alessandro Rubini <rubini-list@gnudd.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH/RFC] net: defragment IP packets
Date: Mon, 27 Jul 2009 14:13:24 +0200	[thread overview]
Message-ID: <20090727121324.GA29825@mail.gnudd.com> (raw)
In-Reply-To: <200907262059.34188.rgetz@blackfin.uclinux.org>

Thanks for your comments.

> Should have a CONFIG_ something - to make this conditional.

This has been asked by Ben too. Will do, although I'm not very happy
about all those conditionals for every few lines of code.

Some of your remarks are just symptoms of this being a quick hack,
like the memcpy not checked, the missed getenv and so on.

> and I was doing md5 or sha1 on things to make sure that things came over 
> properly...

Yes, me too. Besides booting the stuff I got.

/alessandro

  reply	other threads:[~2009-07-27 12:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-24  8:04 [U-Boot] [PATCH/RFC] net: defragment IP packets Alessandro Rubini
2009-07-25 22:09 ` Robin Getz
2009-07-26  2:02   ` Jerry Van Baren
2009-07-26  4:44     ` Robin Getz
2009-07-26 20:23       ` Alessandro Rubini
2009-07-27  0:19         ` Robin Getz
2009-07-27  5:08         ` Ben Warren
2009-07-27 11:46           ` Robin Getz
2009-07-27  0:59 ` Robin Getz
2009-07-27 12:13   ` Alessandro Rubini [this message]
2009-07-27 12:52     ` Robin Getz
2009-07-27 12:41   ` Wolfgang Denk
2009-07-27 12:50     ` Robin Getz
2009-07-27 11:41 ` Robin Getz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090727121324.GA29825@mail.gnudd.com \
    --to=rubini-list@gnudd.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox