From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Refresh LZMA-lib to v4.65
Date: Mon, 27 Jul 2009 15:33:11 -0400 [thread overview]
Message-ID: <200907271533.11942.vapier@gentoo.org> (raw)
In-Reply-To: <b73e93990907271212vd6d4721o295a6bdf2f9e1557@mail.gmail.com>
On Monday 27 July 2009 15:12:11 Luigi Mantellini wrote:
> On Mon, Jul 27, 2009 at 8:58 PM, Mike Frysinger<vapier@gentoo.org> wrote:
> >> CFLAGS bugs?
> >> I tried to comment the -I...blablalb... and the build (crrectly) fails.
> >> Can you remove the .depend from your source dir?
> >
> > i said it doesnt matter. but if you're going to continue down this line
> > of reasoning anyways, i just did `git clean -x -d` and got the same
> > result.
>
> Very strange...which compiler are you using?
> I'm using a gcc4.3.3 (buitl using openwrt trunk)
the gcc doesnt matter (but i am using 4.3.3 too). i already pointed out the
issue -- the common .depend code does not use $(CFLAGS), and the lzma code
isnt using proper paths.
just change the *1* include and drop the -I path hack and be done with it.
--- a/lib_generic/lzma/LzmaDec.c
+++ b/lib_generic/lzma/LzmaDec.c
@@ -9 +9 @@
-#include <string.h>
+#include <linux/string.h>
--- a/lib_generic/lzma/Makefile
+++ b/lib_generic/lzma/Makefile
@@ -33 +33 @@ SOBJS =
-CFLAGS += -D_LZMA_PROB32 -I$(TOPDIR)/include/linux
+CFLAGS += -D_LZMA_PROB32
> this is my .depend (after a git clean -x -d -f and after a make mrproper):
>
> LzmaTools.o: LzmaTools.c /mnt/devel/onu/u-boot-onu/include/config.h \
i said LzmaDec.c, not LzmaTools.c
just run:
$ touch lib_generic/lzma/LzmaDec.c
$ make depend SUBDIRS=lib_generic/lzma
for dir in lib_generic/lzma ; do make -C $dir _depend ; done
make[1]: Entering directory `/usr/local/src/u-boot/blackfin/lib_generic/lzma'
LzmaDec.c:9:20: error: string.h: No such file or directory
make[1]: Leaving directory `/usr/local/src/u-boot/blackfin/lib_generic/lzma'
make[1]: Entering directory `/usr/local/src/u-boot/blackfin/lib_generic/lzma'
make[1]: Nothing to be done for `_depend'.
make[1]: Leaving directory `/usr/local/src/u-boot/blackfin/lib_generic/lzma'
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090727/6421c4ac/attachment.pgp
next prev parent reply other threads:[~2009-07-27 19:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-21 8:45 [U-Boot] Refresh LZMA-lib to v4.65 (v3 resend) Luigi 'Comio' Mantellini
2009-07-21 8:45 ` [U-Boot] [PATCH] Refresh LZMA-lib to v4.65 Luigi 'Comio' Mantellini
2009-07-22 7:53 ` Wolfgang Denk
2009-07-22 10:28 ` [U-Boot] [PATCH] add WATCHDOG_RESET to allow LZMA kernel decompression on slow machines rhabarber1848
2009-07-23 19:56 ` Wolfgang Denk
2009-07-24 6:16 ` [U-Boot] [PATCH v2] " rhabarber1848 at web.de
2009-07-26 22:16 ` Wolfgang Denk
2009-07-26 22:36 ` Mike Frysinger
2009-07-22 11:34 ` [U-Boot] [PATCH] Refresh LZMA-lib to v4.65 Luigi 'Comio' Mantellini
2009-07-27 17:40 ` Mike Frysinger
2009-07-27 18:17 ` Luigi Mantellini
2009-07-27 18:27 ` Mike Frysinger
2009-07-27 18:48 ` Luigi Mantellini
2009-07-27 18:58 ` Mike Frysinger
2009-07-27 19:12 ` Luigi Mantellini
2009-07-27 19:33 ` Mike Frysinger [this message]
2009-07-27 19:45 ` Luigi Mantellini
2009-07-27 20:02 ` Luigi Mantellini
2009-07-27 20:49 ` Wolfgang Denk
2009-07-27 21:04 ` Luigi Mantellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907271533.11942.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox