From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] OneNAND: S5PC100 OneNAND IPL support
Date: Tue, 28 Jul 2009 15:42:17 +0200 [thread overview]
Message-ID: <20090728134217.GK5259@game.jcrosoft.org> (raw)
In-Reply-To: <9c9fda240907271558g5b7275b6t611e2137474c22f4@mail.gmail.com>
On 07:58 Tue 28 Jul , Kyungmin Park wrote:
> On Tue, Jul 28, 2009 at 5:09 AM, Jean-Christophe
> PLAGNIOL-VILLARD<plagnioj@jcrosoft.com> wrote:
> > On 14:28 Fri 24 Jul ? ? , Kyungmin Park wrote:
> >> On Fri, Jul 24, 2009 at 7:42 AM, Jean-Christophe
> >> PLAGNIOL-VILLARD<plagnioj@jcrosoft.com> wrote:
> >> > On 09:55 Tue 21 Jul ? ? , Kyungmin Park wrote:
> >> >> S5PC100 has own OneNAND controller and has different interface.
> >> >> OneNAND IPL use it to S5PC100 board.
> >> >>
> >> >> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> >> >> ---
> >> > is there any better than put soc specific code in generic implementatioN
> >> >
> >>
> >> I hope so. only s3c64xx series and s5pc100 use own OneNAND controller.
> >> I also don't understand why need these controller. The OneNAND has its
> >> own controller at chips already.
> > I known
> > so what do you propose?
> >
>
> just commit the patch I sent. It's difficult to remove the ifdef since
> size limitation.
I understand your problem of size but is there any otherway to do ti without
the onenand soc controler ?
I'll prefer we find a way to not put soc specific code in the generic code
maybe we can crete a header which will be soc specific or a generic that we
will include depending on the soc
Best Regards,
J.
next prev parent reply other threads:[~2009-07-28 13:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-21 0:55 [U-Boot] [PATCH] OneNAND: S5PC100 OneNAND IPL support Kyungmin Park
2009-07-23 22:42 ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-24 5:28 ` Kyungmin Park
2009-07-27 20:09 ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-27 22:58 ` Kyungmin Park
2009-07-28 13:42 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2009-07-28 23:06 ` Kyungmin Park
2009-07-30 19:16 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090728134217.GK5259@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox