From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ppc4xx: Support PPC460EX rev B on gdsys CompactCenter
Date: Thu, 30 Jul 2009 09:11:05 +0200 [thread overview]
Message-ID: <200907300911.06052.sr@denx.de> (raw)
In-Reply-To: <1248936376-32415-1-git-send-email-eibach@gdsys.de>
Hi Dirk,
On Thursday 30 July 2009 08:46:16 Dirk Eibach wrote:
> This patch is based on a patch for canyonlands by Stefan Roese.
>
> Signed-off-by: Dirk Eibach <eibach@gdsys.de>
> ---
> board/gdsys/compactcenter/compactcenter.c | 16 ++++++++++++----
> 1 files changed, 12 insertions(+), 4 deletions(-)
>
> diff --git a/board/gdsys/compactcenter/compactcenter.c
> b/board/gdsys/compactcenter/compactcenter.c index 477ef70..4861cc8 100644
> --- a/board/gdsys/compactcenter/compactcenter.c
> +++ b/board/gdsys/compactcenter/compactcenter.c
> @@ -39,10 +39,19 @@ DECLARE_GLOBAL_DATA_PTR;
>
> #define CONFIG_SYS_BCSR3_PCIE 0x10
>
> -int board_early_init_f(void)
> +static int pvr_460ex(void)
> {
> u32 pvr = get_pvr();
>
> + if ((pvr == PVR_460EX_RA) || (pvr == PVR_460EX_SE_RA) ||
> + (pvr == PVR_460EX_RB))
> + return 1;
> +
> + return 0;
> +}
Do you really need this 460EX check at all on your boards? It's only needed on
Canyonlands since this board port also support Glacier 460GT. From looking at
your port, you don't need to support 460GT at all. So you could easily drop
all these 460EX checks in your code.
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
prev parent reply other threads:[~2009-07-30 7:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-30 6:46 [U-Boot] [PATCH] ppc4xx: Support PPC460EX rev B on gdsys CompactCenter Dirk Eibach
2009-07-30 7:11 ` Stefan Roese [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907300911.06052.sr@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox