public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH]omap3: bug fix for NOR boot support
@ 2009-07-30 18:36 Penda, Naveen Kumar
  2009-07-30 18:55 ` Dirk Behme
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Penda, Naveen Kumar @ 2009-07-30 18:36 UTC (permalink / raw)
  To: u-boot

From: Penda Naveen Kumar<pnaveen@ti.com>

This patch provides bug fix, when omap3 uses nor boot.
 
Signed-off-by: Penda Naveen Kumar<pnaveen@ti.com>

Index: u-boot/cpu/arm_cortexa8/omap3/lowlevel_init.S
===================================================================
--- u-boot.orig/cpu/arm_cortexa8/omap3/lowlevel_init.S
+++ u-boot/cpu/arm_cortexa8/omap3/lowlevel_init.S
@@ -135,19 +135,19 @@ _go_to_speed: .word go_to_speed
 /* these constants need to be close for PIC code */
 /* The Nor has to be in the Flash Base CS0 for this condition to happen */
 flash_cfg1_addr:
-	.word (GPMC_CONFIG_CS0 + GPMC_CONFIG1)
+	.word (GPMC_CONFIG_CS0_BASE + GPMC_CONFIG1)
 flash_cfg3_addr:
-	.word (GPMC_CONFIG_CS0 + GPMC_CONFIG3)
+	.word (GPMC_CONFIG_CS0_BASE + GPMC_CONFIG3)
 flash_cfg3_val:
 	.word STNOR_GPMC_CONFIG3
 flash_cfg4_addr:
-	.word (GPMC_CONFIG_CS0 + GPMC_CONFIG4)
+	.word (GPMC_CONFIG_CS0_BASE + GPMC_CONFIG4)
 flash_cfg4_val:
 	.word STNOR_GPMC_CONFIG4
 flash_cfg5_val:
 	.word STNOR_GPMC_CONFIG5
 flash_cfg5_addr:
-	.word (GPMC_CONFIG_CS0 + GPMC_CONFIG5)
+	.word (GPMC_CONFIG_CS0_BASE + GPMC_CONFIG5)
 pll_ctl_add:
 	.word CM_CLKEN_PLL
 pll_div_add1:

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH]omap3: bug fix for NOR boot support
  2009-07-30 18:36 [U-Boot] [PATCH]omap3: bug fix for NOR boot support Penda, Naveen Kumar
@ 2009-07-30 18:55 ` Dirk Behme
  2009-08-01  9:41 ` Jean-Christophe PLAGNIOL-VILLARD
  2009-08-08 10:00 ` Wolfgang Denk
  2 siblings, 0 replies; 4+ messages in thread
From: Dirk Behme @ 2009-07-30 18:55 UTC (permalink / raw)
  To: u-boot

Penda, Naveen Kumar wrote:
> From: Penda Naveen Kumar<pnaveen@ti.com>
> 
> This patch provides bug fix, when omap3 uses nor boot.
>  
> Signed-off-by: Penda Naveen Kumar<pnaveen@ti.com>

Makes sense! Most probably not found earlier because most OMAP3 boards 
have no NOR.

Acked-by: Dirk Behme <dirk.behme@googlemail.com>

> Index: u-boot/cpu/arm_cortexa8/omap3/lowlevel_init.S
> ===================================================================
> --- u-boot.orig/cpu/arm_cortexa8/omap3/lowlevel_init.S
> +++ u-boot/cpu/arm_cortexa8/omap3/lowlevel_init.S
> @@ -135,19 +135,19 @@ _go_to_speed: .word go_to_speed
>  /* these constants need to be close for PIC code */
>  /* The Nor has to be in the Flash Base CS0 for this condition to happen */
>  flash_cfg1_addr:
> -	.word (GPMC_CONFIG_CS0 + GPMC_CONFIG1)
> +	.word (GPMC_CONFIG_CS0_BASE + GPMC_CONFIG1)
>  flash_cfg3_addr:
> -	.word (GPMC_CONFIG_CS0 + GPMC_CONFIG3)
> +	.word (GPMC_CONFIG_CS0_BASE + GPMC_CONFIG3)
>  flash_cfg3_val:
>  	.word STNOR_GPMC_CONFIG3
>  flash_cfg4_addr:
> -	.word (GPMC_CONFIG_CS0 + GPMC_CONFIG4)
> +	.word (GPMC_CONFIG_CS0_BASE + GPMC_CONFIG4)
>  flash_cfg4_val:
>  	.word STNOR_GPMC_CONFIG4
>  flash_cfg5_val:
>  	.word STNOR_GPMC_CONFIG5
>  flash_cfg5_addr:
> -	.word (GPMC_CONFIG_CS0 + GPMC_CONFIG5)
> +	.word (GPMC_CONFIG_CS0_BASE + GPMC_CONFIG5)
>  pll_ctl_add:
>  	.word CM_CLKEN_PLL
>  pll_div_add1:
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH]omap3: bug fix for NOR boot support
  2009-07-30 18:36 [U-Boot] [PATCH]omap3: bug fix for NOR boot support Penda, Naveen Kumar
  2009-07-30 18:55 ` Dirk Behme
@ 2009-08-01  9:41 ` Jean-Christophe PLAGNIOL-VILLARD
  2009-08-08 10:00 ` Wolfgang Denk
  2 siblings, 0 replies; 4+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2009-08-01  9:41 UTC (permalink / raw)
  To: u-boot

On 00:06 Fri 31 Jul     , Penda, Naveen Kumar wrote:
> From: Penda Naveen Kumar<pnaveen@ti.com>
> 
> This patch provides bug fix, when omap3 uses nor boot.
>  
> Signed-off-by: Penda Naveen Kumar<pnaveen@ti.com>
please specify on which board you test it

Best Regards,
J.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH]omap3: bug fix for NOR boot support
  2009-07-30 18:36 [U-Boot] [PATCH]omap3: bug fix for NOR boot support Penda, Naveen Kumar
  2009-07-30 18:55 ` Dirk Behme
  2009-08-01  9:41 ` Jean-Christophe PLAGNIOL-VILLARD
@ 2009-08-08 10:00 ` Wolfgang Denk
  2 siblings, 0 replies; 4+ messages in thread
From: Wolfgang Denk @ 2009-08-08 10:00 UTC (permalink / raw)
  To: u-boot

Dear "Penda, Naveen Kumar",

In message <5A47E75E594F054BAF48C5E4FC4B92AB0305F29A9A@dbde02.ent.ti.com> you wrote:
> From: Penda Naveen Kumar<pnaveen@ti.com>
> 
> This patch provides bug fix, when omap3 uses nor boot.
>  
> Signed-off-by: Penda Naveen Kumar<pnaveen@ti.com>
> 
> Index: u-boot/cpu/arm_cortexa8/omap3/lowlevel_init.S
> ===================================================================
> --- u-boot.orig/cpu/arm_cortexa8/omap3/lowlevel_init.S
> +++ u-boot/cpu/arm_cortexa8/omap3/lowlevel_init.S

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There is nothing in this world constant but inconstancy.      - Swift

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2009-08-08 10:00 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-30 18:36 [U-Boot] [PATCH]omap3: bug fix for NOR boot support Penda, Naveen Kumar
2009-07-30 18:55 ` Dirk Behme
2009-08-01  9:41 ` Jean-Christophe PLAGNIOL-VILLARD
2009-08-08 10:00 ` Wolfgang Denk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox