From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] imx27lite: add support for imx27lite board from LogicPD
Date: Mon, 3 Aug 2009 14:17:48 +0200 [thread overview]
Message-ID: <20090803121748.GG15665@game.jcrosoft.org> (raw)
In-Reply-To: <20090803081938.798878340728@gemini.denx.de>
On 10:19 Mon 03 Aug , Wolfgang Denk wrote:
> Dear Jean-Christophe PLAGNIOL-VILLARD,
>
> In message <20090803053218.GA15665@game.jcrosoft.org> you wrote:
> >
> ...
> > > +/* malloc() len */
> > > +#define CONFIG_SYS_MALLOC_LEN (0x10000 + 256 * 1024)
> > please do not mix hexa and decimal
I've as there is other think to fix otherwise I'll not have ask
>
> Please be reasonable. This is a perfectly valid and easy to read
> notation. I see no reason to change this - anything else would
> probably be much harder to read.
>
> > > +#define CONFIG_LOADADDR 0xa0800000 /* loadaddr env var */
> > > +#define CONFIG_SYS_LOAD_ADDR CONFIG_LOADADDR
> > why 2?
>
> Because they do different things.
I've take a look they do nearly the same think it will be better to avoid have
2 configs specialy when there are the same
btw I've found nothing about it in the README
Best Regards,
J.
next prev parent reply other threads:[~2009-08-03 12:17 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-08 0:12 [U-Boot] [PATCH 0/7][v3] Support for LogicPD i.MX27-LITEKIT development board Ilya Yanok
2009-06-08 0:12 ` [U-Boot] [PATCH 1/7] mx27: basic cpu support Ilya Yanok
2009-06-20 13:13 ` Jean-Christophe PLAGNIOL-VILLARD
2009-06-08 0:12 ` [U-Boot] [PATCH 2/7] serial_mx31: allow it to work with mx27 too and rename to serial_mxc Ilya Yanok
2009-06-20 13:18 ` Jean-Christophe PLAGNIOL-VILLARD
2009-06-08 0:12 ` [U-Boot] [PATCH 3/7] fec_imx27: driver for FEC ethernet controller on i.MX27 Ilya Yanok
2009-07-17 10:57 ` [U-Boot] [PATCH] fec_mxc: " Ilya Yanok
2009-07-17 14:05 ` Ben Warren
2009-07-21 15:32 ` Ilya Yanok
2009-07-22 22:23 ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-22 23:03 ` Ben Warren
2009-07-23 6:28 ` Ben Warren
2009-06-08 0:12 ` [U-Boot] [PATCH 4/7] mxc_nand: add nand driver for MX2/MX3 Ilya Yanok
2009-06-20 13:22 ` Jean-Christophe PLAGNIOL-VILLARD
2009-06-22 23:43 ` Scott Wood
2009-06-23 20:03 ` Magnus Lilja
2009-07-03 19:03 ` Paul Thomas
2009-07-03 19:11 ` Paul Thomas
2009-07-17 10:48 ` Ilya Yanok
2009-07-17 10:53 ` [U-Boot] [PATCH] " Ilya Yanok
2009-07-22 21:33 ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-28 22:37 ` Scott Wood
2009-08-03 1:45 ` Ilya Yanok
2009-08-04 23:32 ` Scott Wood
2009-08-10 22:32 ` Ilya Yanok
2009-08-11 22:53 ` Scott Wood
2009-08-03 2:01 ` Ilya Yanok
2009-08-03 16:58 ` Scott Wood
2009-07-17 16:00 ` [U-Boot] [PATCH 4/7] " Scott Wood
2009-06-08 0:12 ` [U-Boot] [PATCH 5/7] mxc-mmc: sdhc host driver for MX2 and MX3 proccessor Ilya Yanok
2009-06-21 11:04 ` Jean-Christophe PLAGNIOL-VILLARD
2009-06-23 23:02 ` alfred steele
2009-08-07 20:13 ` Jean-Christophe PLAGNIOL-VILLARD
2009-06-08 0:12 ` [U-Boot] [PATCH 6/7] arm: add support for CONFIG_GENERIC_MMC Ilya Yanok
2009-06-20 13:20 ` Jean-Christophe PLAGNIOL-VILLARD
2009-06-08 0:12 ` [U-Boot] [PATCH 7/7] imx27lite: add support for imx27lite board from LogicPD Ilya Yanok
2009-06-21 11:21 ` Jean-Christophe PLAGNIOL-VILLARD
2009-06-23 16:55 ` Detlev Zundel
2009-07-07 19:24 ` Wolfgang Denk
2009-07-17 11:00 ` [U-Boot] [PATCH] " Ilya Yanok
2009-07-22 21:37 ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-22 22:17 ` Ilya Yanok
2009-07-23 21:37 ` Jean-Christophe PLAGNIOL-VILLARD
2009-08-03 1:46 ` Ilya Yanok
2009-08-03 5:32 ` Jean-Christophe PLAGNIOL-VILLARD
2009-08-03 8:19 ` Wolfgang Denk
2009-08-03 12:17 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2009-08-03 14:35 ` Wolfgang Denk
2009-08-05 10:09 ` javier Martin
2009-08-05 12:30 ` javier Martin
2009-08-05 12:45 ` Wolfgang Denk
2009-08-05 14:17 ` javier Martin
2009-08-05 14:21 ` Wolfgang Denk
2009-08-05 15:01 ` javier Martin
2009-08-06 20:10 ` Wolfgang Denk
2009-08-07 7:18 ` javier Martin
2009-08-07 9:13 ` Wolfgang Denk
2009-08-06 19:29 ` [U-Boot] [PATCH] ARM EABI: add new helper functions resp. function names Wolfgang Denk
2009-08-08 6:50 ` Dirk Behme
2009-08-08 7:16 ` Wolfgang Denk
2009-08-08 7:39 ` Dirk Behme
2009-08-09 21:28 ` Wolfgang Denk
2009-08-10 22:32 ` [U-Boot] [PATCH] imx27lite: add support for imx27lite board from LogicPD Ilya Yanok
2009-08-11 18:47 ` Fabio Estevam
2009-08-11 19:12 ` Ilya Yanok
2009-08-14 7:03 ` Jean-Christophe PLAGNIOL-VILLARD
2009-08-26 20:14 ` Wolfgang Denk
2009-08-26 20:43 ` Scott Wood
2009-09-01 20:10 ` Jean-Christophe PLAGNIOL-VILLARD
2009-06-28 9:52 ` [U-Boot] [PATCH 0/7][v3] Support for LogicPD i.MX27-LITEKIT development board Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090803121748.GG15665@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox