From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] Support for the Calao TNY-A9260/TNY-A9G20 boards
Date: Wed, 5 Aug 2009 21:30:11 +0200 [thread overview]
Message-ID: <20090805193011.GD13346@game.jcrosoft.org> (raw)
In-Reply-To: <1249492602-5725-2-git-send-email-albin.tonnerre@free-electrons.com>
Some general comment
please add space before and after '*' & co
and the ligne length limit in 80 chars
> +/* Env, bootstrap and u-boot in NAND */
> +#ifdef CONFIG_ENV_IS_IN_NAND
> +#define CONFIG_ENV_OFFSET 0x60000
> +#define CONFIG_ENV_OFFSET_REDUND 0x80000
> +#define CONFIG_ENV_SIZE 0x20000
> +#endif
> +
> +#define CONFIG_BOOTCOMMAND "nboot 0x21000000 0 400000"
> +#define CONFIG_BOOTARGS "console=ttyS0,115200 " \
> + "root=/dev/mtdblock1 " \
> + "mtdparts=atmel_nand:16M(kernel)ro," \
> + "120M(rootfs),-(other) " \
> + "rw rootfstype=jffs2"
here as example
> +
> +#define CONFIG_BAUDRATE 115200
> +#define CONFIG_SYS_BAUDRATE_TABLE {115200 , 19200, 38400, 57600, 9600 }
> +
> +#define CONFIG_SYS_PROMPT "U-Boot> "
> +#define CONFIG_SYS_CBSIZE 256
> +#define CONFIG_SYS_MAXARGS 16
> +#define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + sizeof(CONFIG_SYS_PROMPT) + 16)
> +#define CONFIG_SYS_LONGHELP 1
> +#define CONFIG_CMDLINE_EDITING 1
> +
> +/*
> + * Size of malloc() pool
> + */
> +#define CONFIG_SYS_MALLOC_LEN ROUND(3 * CONFIG_ENV_SIZE + 128*1024, 0x1000)
> +#define CONFIG_SYS_GBL_DATA_SIZE 128 /* 128 bytes for initial data */
> +
> +#define CONFIG_STACKSIZE (32*1024) /* regular stack */
here too etc..
> +
> +#ifdef CONFIG_USE_IRQ
> +#error CONFIG_USE_IRQ not supported
> +#endif
Best Regards,
J.
next prev parent reply other threads:[~2009-08-05 19:30 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-21 15:53 [U-Boot] [PATCH] Support for the Calao TNY-A9260 board Albin Tonnerre
2009-07-21 17:40 ` Wolfgang Denk
2009-07-21 18:02 ` Albin Tonnerre
2009-07-22 7:33 ` Wolfgang Denk
2009-07-22 8:16 ` Albin Tonnerre
2009-07-22 9:47 ` Wolfgang Denk
2009-07-22 11:03 ` Albin Tonnerre
2009-07-22 11:13 ` Wolfgang Denk
2009-07-24 8:32 ` [U-Boot] [PATCH] Support for the Calao TNY-A9260/TNY-A9G20 boards Albin Tonnerre
2009-08-01 14:15 ` Jean-Christophe PLAGNIOL-VILLARD
2009-08-03 7:54 ` Albin Tonnerre
2009-08-04 19:45 ` Jean-Christophe PLAGNIOL-VILLARD
2009-08-05 17:16 ` [U-Boot] [PATCH 1/2] Add driver for the ST M95xxx SPI EEPROM Albin Tonnerre
2009-08-05 17:16 ` [U-Boot] [PATCH 2/2] Support for the Calao TNY-A9260/TNY-A9G20 boards Albin Tonnerre
2009-08-05 19:30 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2009-08-05 19:45 ` Albin Tonnerre
2009-08-05 19:58 ` Jean-Christophe PLAGNIOL-VILLARD
2009-08-07 10:37 ` [U-Boot] [PATCH 1/2] Add driver for the ST M95xxx SPI EEPROM Albin Tonnerre
2009-08-07 10:37 ` [U-Boot] [PATCH 2/2] Support for the Calao TNY-A9260/TNY-A9G20 boards Albin Tonnerre
2009-08-07 10:54 ` Jean-Christophe PLAGNIOL-VILLARD
2009-08-09 20:38 ` Wolfgang Denk
2009-08-09 22:40 ` Albin Tonnerre
2009-08-11 10:44 ` [U-Boot] [PATCH] " Albin Tonnerre
2009-08-17 21:41 ` Jean-Christophe PLAGNIOL-VILLARD
2009-08-17 22:13 ` Albin Tonnerre
2009-08-17 22:48 ` Jean-Christophe PLAGNIOL-VILLARD
2009-08-18 8:26 ` Albin Tonnerre
2009-08-19 19:14 ` Albin Tonnerre
2009-08-19 21:30 ` Jean-Christophe PLAGNIOL-VILLARD
2009-08-20 13:43 ` Albin Tonnerre
2009-08-20 14:44 ` Jean-Christophe PLAGNIOL-VILLARD
2009-08-20 14:04 ` [U-Boot] [PATCH v8] " Albin Tonnerre
2009-09-01 20:53 ` Jean-Christophe PLAGNIOL-VILLARD
2009-08-07 10:52 ` [U-Boot] [PATCH 1/2] Add driver for the ST M95xxx SPI EEPROM Jean-Christophe PLAGNIOL-VILLARD
2009-08-05 19:24 ` Jean-Christophe PLAGNIOL-VILLARD
2009-08-07 10:40 ` Albin Tonnerre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090805193011.GD13346@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox