From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Date: Wed, 5 Aug 2009 21:30:11 +0200
Subject: [U-Boot] [PATCH 2/2] Support for the Calao TNY-A9260/TNY-A9G20
	boards
In-Reply-To: <1249492602-5725-2-git-send-email-albin.tonnerre@free-electrons.com>
References: <20090804194520.GB4638@game.jcrosoft.org>
	<1249492602-5725-1-git-send-email-albin.tonnerre@free-electrons.com>
	<1249492602-5725-2-git-send-email-albin.tonnerre@free-electrons.com>
Message-ID: <20090805193011.GD13346@game.jcrosoft.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Some general comment
please add space before and after '*' & co
and the ligne length limit in 80 chars
> +/* Env, bootstrap and u-boot in NAND */
> +#ifdef CONFIG_ENV_IS_IN_NAND
> +#define CONFIG_ENV_OFFSET 0x60000
> +#define CONFIG_ENV_OFFSET_REDUND 0x80000
> +#define CONFIG_ENV_SIZE 0x20000
> +#endif
> +
> +#define CONFIG_BOOTCOMMAND	"nboot 0x21000000 0 400000"
> +#define CONFIG_BOOTARGS		"console=ttyS0,115200 " \
> +							"root=/dev/mtdblock1 " \
> +							"mtdparts=atmel_nand:16M(kernel)ro," \
> +							"120M(rootfs),-(other) " \
> +							"rw rootfstype=jffs2"
here as example
> +
> +#define CONFIG_BAUDRATE		115200
> +#define CONFIG_SYS_BAUDRATE_TABLE	{115200 , 19200, 38400, 57600, 9600 }
> +
> +#define CONFIG_SYS_PROMPT		"U-Boot> "
> +#define CONFIG_SYS_CBSIZE		256
> +#define CONFIG_SYS_MAXARGS		16
> +#define CONFIG_SYS_PBSIZE		(CONFIG_SYS_CBSIZE + sizeof(CONFIG_SYS_PROMPT) + 16)
> +#define CONFIG_SYS_LONGHELP		1
> +#define CONFIG_CMDLINE_EDITING	1
> +
> +/*
> + * Size of malloc() pool
> + */
> +#define CONFIG_SYS_MALLOC_LEN		ROUND(3 * CONFIG_ENV_SIZE + 128*1024, 0x1000)
> +#define CONFIG_SYS_GBL_DATA_SIZE	128	/* 128 bytes for initial data */
> +
> +#define CONFIG_STACKSIZE	(32*1024)	/* regular stack */
here too etc..
> +
> +#ifdef CONFIG_USE_IRQ
> +#error CONFIG_USE_IRQ not supported
> +#endif
Best Regards,
J.