[U-Boot] [PATCH 2/2] Support for the Calao TNY-A9260/TNY-A9G20 boards

Albin Tonnerre
2009-08-09T22:40:48Z

On Sun, Aug 09, 2009 at 10:38:25PM +0200, Wolfgang Denk wrote :
> Dear Albin Tonnerre,

Hi Wolfgang,

> In message <1249641457-16887-2-git-send-email-albin.tonnerre@free-electrons.com> you wrote:
> > +tny_a9g20_nandflash_config \
> > +tny_a9g20_eeprom_config \
> > +tny_a9g20_config \
> > +tny_a9260_nandflash_config \
> > +tny_a9260_eeprom_config \
> > +tny_a9260_config : unconfig
> > + @mkdir -p $(obj)include
> > + @if [ "$(findstring _nandflash,$@)" ] ; then \
> > + echo "#define CONFIG_ENV_IS_IN_NAND" >>$(obj)include/config.h ; \
> > + else \
> > + echo "#define CONFIG_ENV_IS_IN_EEPROM" >>$(obj)include/config.h ; \
> > + fi;
> > + @if [ "$(findstring _a9g20,$@)" ] ; then \
> > + echo "#define CONFIG_TNY_A9G20" >>$(obj)include/config.h ; \
> > + else \
> > + echo "#define CONFIG_TNY_A9260" >>$(obj)include/config.h ; \
> > + fi;
> > + @$(MKCONFIG) -a tny_a9260 arm arm926ejs tny_a9260 calao at91
>
> Please do not add such scripting to the top level Makefile. Perform it
> in your board config file instead.
>
> For an example, please see
> http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/65499

Thanks for the pointer. As the patch is already part of Jean-Christophe's ARM
pull request, do you mind if I provide a patch on top of the current one to fix
the issue, or do you want me to resubmit the whole patch ?

Regards,
--
Albin Tonnerre, Free Electrons
Kernel, drivers and embedded Linux development,
consulting, training and support.