[U-Boot] [PATCH] Support for the Calao TNY-A9260 board

Wolfgang Denk
2009-07-21T17:40:39Z

Dear Albin Tonnerre,

In message <1248191599-23258-1-git-send-email-albin.tonnerre@free-electrons.com> you wrote:
> The Calao TNY-A9260 board is a board manufactured and sold by Calao
> Systems <http://www.calao-systems.com>. Its components are very
> similar to the AT91SAM9260EK board, so its configuration is based on
> the configuration of this board. There are however some differences:
> different clocks, no LCD, no ethernet. It also uses SPI EEPROM to store
> the environment.
> The SPI chip is a STM95080, and as it's used in a number of CALAO boards
> which should be supported soon, the corresponding spi_read and spi_write
> functions have been put in drivers/spi/eeprom_m95xxx.c
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 575a7ec..1ba1921 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -624,6 +624,10 @@ Peter Pearse <peter.pearse@arm.com>
> versatile ARM926EJ-S
> versatile ARM926EJ-S
>
> +Albin Tonnerre <albin.tonnerre@free-electrons.com>
> +
> + tny_a9260 ARM926EJS (AT91SAM9260 SoC)
> +
> Dave Peverley <dpeverley@mpc-data.co.uk>
>
> omap730p2 ARM926EJS

Please keep list of names alphabetically sorted.

> diff --git a/MAKEALL b/MAKEALL
> index 020ff73..59b65d2 100755
> --- a/MAKEALL
> +++ b/MAKEALL
> @@ -599,6 +599,7 @@ LIST_at91=" \
> m501sk \
> pm9261 \
> pm9263 \
> + tny_a9260 \
> "
>
> #########################################################################
> diff --git a/Makefile b/Makefile
> index 25a6254..d05abd9 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2807,6 +2807,18 @@ at91sam9g45ekes_config : unconfig
> pm9263_config : unconfig
> @$(MKCONFIG) $(@:_config=) arm arm926ejs pm9263 ronetix at91
>
> +tny_a9260_nandflash_config \
> +tny_a9260_eeprom_config \
> +tny_a9260_config : unconfig
> + @if [ "$(findstring _nandflash,$@)" ] ; then \
> + $(XECHO) "#define CONFIG_ENV_IS_IN_NAND" >>$(obj)include/config.h ; \
> + $(XECHO) "... with environment variable in NAND FLASH" ; \
> + else \
> + $(XECHO) "#define CONFIG_ENV_IS_IN_EEPROM" >>$(obj)include/config.h ; \
> + $(XECHO) "... with environment variable in SPI EEPROM CS1" ; \
> + fi;
> + @$(MKCONFIG) -a tny_a9260 arm arm926ejs tny_a9260 calao at91

Do we need such verbosity? And is there really only a single
environment variable as the message claims?

...
> +int dram_init(void)
> +{
> + gd->bd->bi_dram[0].start = PHYS_SDRAM;
> + gd->bd->bi_dram[0].size = get_ram_size(PHYS_SDRAM, PHYS_SDRAM_SIZE);
> + return 0;

Hm... no error checking here?

...
> diff --git a/include/configs/tny_a9260.h b/include/configs/tny_a9260.h
> new file mode 100644
> index 0000000..1dcbb97
> --- /dev/null
> +++ b/include/configs/tny_a9260.h
...
> +#define ROUND(A, B) (((A) + (B)) & ~((B) - 1))

Please do not redefine.

Don't you get a warning message at least?

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Documentation is the castor oil of programming.
Managers know it must be good because the programmers hate it so much.