From: Alessandro Rubini <rubini-list@gnudd.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] PATCH mtd CFI flash: timeout calculation underflow if imprecise 1kHz timer: fix
Date: Thu, 6 Aug 2009 15:31:10 +0200 [thread overview]
Message-ID: <20090806133110.GA26906@mail.gnudd.com> (raw)
In-Reply-To: <20090806132213.2672E832E416@gemini.denx.de>
>> + tout = tout * CONFIG_SYS_HZ / 1000 + 1;
> 2) There should be a Signed-off-by: from Alessandro, too.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>
> 5) Omit the "+1". It seems bogus to me.
Since the timeout is an error condition, It's better to have it longer
than shorter. Since integer division truncates towards 0, I'd better
give my hardware more time before signalling an error (an unlikely
situation), rather than timing out on an operation that would complete
in the expected time. This happens with low HZ values, which I know
are discouraged nowadays.
Not a big issue, anyway, I'm fine either way.
/alessandro
next prev parent reply other threads:[~2009-08-06 13:31 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-06 13:09 [U-Boot] PATCH mtd CFI flash: timeout calculation underflow if imprecise 1kHz timer: fix Renato Andreola
2009-08-06 13:22 ` Wolfgang Denk
2009-08-06 13:31 ` Alessandro Rubini [this message]
2009-08-06 14:19 ` Wolfgang Denk
2009-08-06 20:26 ` Jean-Christophe PLAGNIOL-VILLARD
2009-08-06 20:53 ` Wolfgang Denk
2009-08-06 21:01 ` Wolfgang Denk
2009-08-06 21:15 ` Jean-Christophe PLAGNIOL-VILLARD
2009-08-06 21:35 ` Wolfgang Denk
2009-08-07 8:15 ` Renato Andreola
2009-08-07 9:16 ` Wolfgang Denk
2009-08-07 10:29 ` [U-Boot] Kirkwood gpio (was: timeout calculation underflow if imprecise 1kHz timer: fix) Alessandro Rubini
2009-08-07 11:13 ` Prafulla Wadaskar
2009-08-07 12:10 ` [U-Boot] Kirkwood gpio Heiko Schocher
2009-08-07 11:46 ` Heiko Schocher
2009-08-07 11:48 ` [U-Boot] Kirkwood gpio (was: timeout calculation underflow if imprecise 1kHz timer: fix) Dieter Kiermaier
2009-08-07 12:14 ` [U-Boot] PATCH mtd CFI flash: timeout calculation underflow if imprecise 1kHz timer: fix Renato Andreola
2009-08-09 21:13 ` Wolfgang Denk
-- strict thread matches above, loose matches on Subject: below --
2009-08-24 8:32 Renato Andreola
2009-08-25 13:25 ` Shinya Kuribayashi
2009-08-25 15:01 ` Renato Andreola
2009-08-25 15:39 ` Stefan Roese
2009-08-25 15:44 ` Stefan Roese
2009-11-22 21:09 ` Wolfgang Denk
2009-11-23 8:51 ` Renato Andreola
2009-11-23 19:36 ` Wolfgang Denk
2009-08-06 16:08 Renato Andreola
2009-08-06 9:49 Renato Andreola
2009-08-06 10:07 ` Wolfgang Denk
2009-08-06 10:12 ` Alessandro Rubini
[not found] ` <4A7AB614.2020509@imagos.it>
2009-08-06 11:40 ` Wolfgang Denk
2009-04-10 12:28 Renato Andreola
2009-04-13 22:09 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090806133110.GA26906@mail.gnudd.com \
--to=rubini-list@gnudd.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox