public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] Add Intel E1000 PCIE card support
Date: Mon, 10 Aug 2009 09:46:01 +0200	[thread overview]
Message-ID: <20090810074601.4C590833DBD2@gemini.denx.de> (raw)
In-Reply-To: <1249018442.19764.4.camel@rock.ap.freescale.net>

Dear Roy Zang,

In message <1249018442.19764.4.camel@rock.ap.freescale.net> you wrote:
> 
> Based on Intel PRO/1000 Network Driver 7.3.20-k2
>   Add Intel E1000 PCIE card support. The following cards are added:
>   INTEL_82571EB_COPPER
>   INTEL_82571EB_FIBER,
>   INTEL_82571EB_SERDES
>   INTEL_82571EB_QUAD_COPPER
>   INTEL_82571PT_QUAD_COPPER
>   INTEL_82571EB_QUAD_FIBER
>   INTEL_82571EB_QUAD_COPPER_LOWPROFILE
>   INTEL_82571EB_SERDES_DUAL
>   INTEL_82571EB_SERDES_QUAD
>   INTEL_82572EI_COPPER
>   INTEL_82572EI_FIBER
>   INTEL_82572EI_SERDES
>   INTEL_82572EI
>   INTEL_82573E
>   INTEL_82573E_IAMT
>   INTEL_82573L
>   INTEL_82546GB_QUAD_COPPER_KSP3
>   INTEL_80003ES2LAN_COPPER_DPT
>   INTEL_80003ES2LAN_SERDES_DPT
>   INTEL_80003ES2LAN_COPPER_SPT
>   INTEL_80003ES2LAN_SERDES_SPT
> 
>  82571EB_COPPER dual ports,
>  82572EI single port,
>  82572EI_COPPER single port PCIE cards
>  and
>  82545EM_COPPER,
>  82541GI_LF
>  pci cards are tested on both  P2020 board
>  and MPC8544DS board.
> 
>  Signed-off-by: Roy Zang <tie-fei.zang@freescale.com>

Unfortunately your driver causes build warnings on the AP1000 board:

e1000.c:131: warning: 'e1000_read_eeprom' used but never defined
e1000.c:2012: warning: 'e1000_set_phy_mode' defined but not used

Please provide a fix.  Thanks in advance.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Suffocating together ... would create heroic camaraderie.
	-- Khan Noonian Singh, "Space Seed", stardate 3142.8

      parent reply	other threads:[~2009-08-10  7:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-31  5:34 [U-Boot] [PATCH v2] Add Intel E1000 PCIE card support Roy Zang
2009-08-08  9:27 ` Ben Warren
2009-08-10  7:46 ` Wolfgang Denk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090810074601.4C590833DBD2@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox