From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/6] net: phy: bugfixes: mv88E61xx multichip addressing support
Date: Mon, 10 Aug 2009 10:09:29 +0200 [thread overview]
Message-ID: <20090810080929.D3E4B833DBD2@gemini.denx.de> (raw)
In-Reply-To: <1247758084-12296-4-git-send-email-prafulla@marvell.com>
Dear Prafulla Wadaskar,
In message <1247758084-12296-4-git-send-email-prafulla@marvell.com> you wrote:
> With these fixes, this driver works properly for multi chip
> addressging mode
>
> Bugfixes:
> 1. Build error fixed for function mv88e61xx_busychk_multic-fixed
> 2. PHY dev address error detection- fixed
> 3. wrong busy bit was refered in function mv88e61xx_busychk -fixed
> 4. invalid data read ptr was refered for RD_PHY in case of
> multichip addressing mode -fixed
>
> The Multichip Address mode is tested with RD6281A board having
> MV88E6165 switch on it
>
> Signed-off-by: Prafulla Wadaskar <prafulla@marvell.com>
> ---
> drivers/net/phy/mv88e61xx.c | 18 +++++++++---------
> drivers/net/phy/mv88e61xx.h | 2 +-
> 2 files changed, 10 insertions(+), 10 deletions(-)
This patch causes compiler warnings:
mv88e61xx.c: In function 'mv88e61xx_busychk_multic':
mv88e61xx.c:46: warning: passing argument 4 of 'miiphy_read' from incompatible pointer type
mv88e61xx.c: In function 'mv88e61xx_wr_phy':
mv88e61xx.c:61: warning: passing argument 4 of 'miiphy_read' from incompatible pointer type
mv88e61xx.c:57: warning: unused variable 'reg'
mv88e61xx.c: In function 'mv88e61xx_rd_phy':
mv88e61xx.c:80: warning: passing argument 4 of 'miiphy_read' from incompatible pointer type
mv88e61xx.c:76: warning: unused variable 'reg'
(when building for the rd6281a board using ELDK 4.2, i. e. gcc-4.2.2)
Also, the rd6281a board throws this warning:
nand_util.c:45:2: warning: #warning Please define CONFIG_SYS_64BIT_VSPRINTF for correct output!
Could you please provide fixes?
Thanks in advance.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"One thing they don't tell you about doing experimental physics is
that sometimes you must work under adverse conditions... like a state
of sheer terror." - W. K. Hartmann
next prev parent reply other threads:[~2009-08-10 8:09 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-16 15:27 [U-Boot] [PATCH 1/6] include/config_cmd_default.h cleanup Prafulla Wadaskar
2009-07-16 15:28 ` [U-Boot] [PATCH v7 2/6] Marvell Sheevaplug Board support Prafulla Wadaskar
2009-07-16 15:28 ` [U-Boot] [PATCH v13 3/6] Marvell MV88F6281GTW_GE " Prafulla Wadaskar
2009-07-16 15:28 ` [U-Boot] [PATCH 4/6] net: phy: bugfixes: mv88E61xx multichip addressing support Prafulla Wadaskar
2009-07-16 15:28 ` [U-Boot] [PATCH 5/6] net: Kirkwood_egiga: forced interface speed config support Prafulla Wadaskar
2009-07-16 14:45 ` Dieter Kiermaier
2009-07-16 15:45 ` Prafulla Wadaskar
2009-07-16 15:28 ` [U-Boot] [PATCH 6/6] Marvell RD6281A Board support Prafulla Wadaskar
2009-07-18 18:48 ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-19 4:50 ` Prafulla Wadaskar
2009-07-18 18:43 ` [U-Boot] [PATCH 5/6] net: Kirkwood_egiga: forced interface speed config support Jean-Christophe PLAGNIOL-VILLARD
2009-07-19 4:54 ` Prafulla Wadaskar
2009-07-21 6:22 ` Ben Warren
2009-07-21 7:39 ` Wolfgang Denk
2009-07-21 19:08 ` Prafulla Wadaskar
2009-07-21 6:51 ` Ben Warren
2009-07-21 7:41 ` Wolfgang Denk
2009-07-21 7:43 ` Ben Warren
2009-07-21 19:01 ` Prafulla Wadaskar
2009-07-21 19:20 ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-21 19:32 ` Lennert Buytenhek
2009-07-21 6:52 ` [U-Boot] [PATCH 4/6] net: phy: bugfixes: mv88E61xx multichip addressing support Ben Warren
2009-08-10 8:09 ` Wolfgang Denk [this message]
2009-08-10 8:25 ` Wolfgang Denk
2009-08-10 8:59 ` Prafulla Wadaskar
2009-08-10 8:31 ` Prafulla Wadaskar
2009-07-18 18:40 ` [U-Boot] [PATCH v13 3/6] Marvell MV88F6281GTW_GE Board support Jean-Christophe PLAGNIOL-VILLARD
2009-07-19 4:55 ` Prafulla Wadaskar
2009-07-16 15:32 ` [U-Boot] [PATCH 6/6][repost] Marvell RD6281A " Prafulla Wadaskar
2009-07-22 22:15 ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-18 17:41 ` [U-Boot] [PATCH v7 2/6] Marvell Sheevaplug " Jean-Christophe PLAGNIOL-VILLARD
2009-07-19 4:56 ` Prafulla Wadaskar
2009-07-17 21:26 ` [U-Boot] [PATCH 1/6] include/config_cmd_default.h cleanup Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090810080929.D3E4B833DBD2@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox