[U-Boot] [PATCH 2/3] net: add getenv/setenv enetaddr function to use ethernet device num

Jean-Christophe PLAGNIOL-VILLARD
2009-08-12T20:58:33Z

On 20:58 Wed 12 Aug , Wolfgang Denk wrote:
> Dear Jean-Christophe PLAGNIOL-VILLARD,
>
> In message <1250023747-20224-2-git-send-email-plagnioj@jcrosoft.com> you wrote:
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > ---
> > include/net.h | 2 ++
> > net/eth.c | 28 +++++++++++++++++++++++++---
> > 2 files changed, 27 insertions(+), 3 deletions(-)
>
> NAK.
>
> First, there are formal issues:
>
> - The subject line is way too long.
why it's only 67 chars
>
> - There is no commit message and no description what this patch is
> supposed to do or to fix. Why should we add it?
just to stop to duplicate this in every driver
>
> > index 2a8a12d..dc4ae41 100644
> > --- a/include/net.h
> > +++ b/include/net.h
> > @@ -124,6 +124,8 @@ extern void eth_set_enetaddr(int num, char* a); /* Set new MAC address */
> > extern void eth_parse_enetaddr(const char *addr, uchar *enetaddr);
> > extern int eth_getenv_enetaddr(char *name, uchar *enetaddr);
> > extern int eth_setenv_enetaddr(char *name, const uchar *enetaddr);
> > +extern int eth_getenv_num_enetaddr(int num, uchar *enetaddr);
> > +extern int eth_setenv_num_enetaddr(int num, const uchar *enetaddr);
>
> What are these functions god for? Are they by any chance duplicationg
> existing code, got example eth_getenv_enetaddr_by_index() ?
the get yes but not there is no set

Best Regards,
J.