public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] net/eth_device: keep index inside each device
Date: Wed, 12 Aug 2009 23:03:39 +0200	[thread overview]
Message-ID: <20090812210339.GE21725@game.jcrosoft.org> (raw)
In-Reply-To: <20090812185054.63898833DBD2@gemini.denx.de>

On 20:50 Wed 12 Aug     , Wolfgang Denk wrote:
> Dear Jean-Christophe PLAGNIOL-VILLARD,
> 
> In message <1250023747-20224-1-git-send-email-plagnioj@jcrosoft.com> you wrote:
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > ---
> >  include/net.h |    1 +
> >  net/eth.c     |   17 +++++------------
> >  2 files changed, 6 insertions(+), 12 deletions(-)
> 
> What exactly is the problem you are addressing with this patch?
> 
> Please provide a commit message that explains what is going on, and
> what is being changed or fixed.
simple it impossible to known what will be your device index in the driver
specially when you have 2 or more drivers instance once or more
so you can not update the mac addres in the env if you want to do it
as we do on smc91111 as we can not known eth%daddr you are
which allow us the avoid to read the eeprom every time we want to use the eth

Best Regards,
J.

  reply	other threads:[~2009-08-12 21:03 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-11 20:49 [U-Boot] [PATCH 1/3] net/eth_device: keep index inside each device Jean-Christophe PLAGNIOL-VILLARD
2009-08-11 20:49 ` [U-Boot] [PATCH 2/3] net: add getenv/setenv enetaddr function to use ethernet device num Jean-Christophe PLAGNIOL-VILLARD
2009-08-11 20:49   ` [U-Boot] [PATCH 3/3] smc91111: switch to MULTI_NET api Jean-Christophe PLAGNIOL-VILLARD
2009-08-12 15:54     ` Ben Warren
2009-08-12 20:38       ` Jean-Christophe PLAGNIOL-VILLARD
2009-08-12 20:46         ` Ben Warren
2009-08-12 19:12     ` Wolfgang Denk
2009-08-12 20:36       ` Jean-Christophe PLAGNIOL-VILLARD
2009-08-12 21:26         ` Wolfgang Denk
2009-08-12 18:58   ` [U-Boot] [PATCH 2/3] net: add getenv/setenv enetaddr function to use ethernet device num Wolfgang Denk
2009-08-12 20:58     ` Jean-Christophe PLAGNIOL-VILLARD
2009-08-12 21:32       ` Wolfgang Denk
2009-08-12 18:50 ` [U-Boot] [PATCH 1/3] net/eth_device: keep index inside each device Wolfgang Denk
2009-08-12 21:03   ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2009-08-12 21:15     ` Ben Warren
2009-08-12 21:26       ` Jean-Christophe PLAGNIOL-VILLARD
2009-08-12 21:46         ` Wolfgang Denk
2009-08-12 23:16         ` Ben Warren
2009-08-12 21:35     ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090812210339.GE21725@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox