public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] OMAP3 Move cache routines to cache.S
Date: Wed, 12 Aug 2009 23:13:16 +0200	[thread overview]
Message-ID: <20090812211316.GF21725@game.jcrosoft.org> (raw)
In-Reply-To: <1250091750-1525-2-git-send-email-Tom.Rix@windriver.com>

On 10:42 Wed 12 Aug     , Tom Rix wrote:
> v7_flush_dcache_all, because it depends on omap ROM code is not
> generic.  Rename the function to 'invalidate_dcache' and move it
> to the omap cpu directory.
> 
> Collect the other omap cache routines l2_cache_enable and
> l2_cache_disable with invalide_dcache into cache.S.  This
> means removing the old cache.c file that contained l2_cache_enable
> and l2_cache_disable.
> 
> The conversion from cache.c to cache.S was done most through
> disassembling the uboot binary.  The only significant change was
> to change the comparision for the return of get_cpu_rev from
> 
>    cmp	r0, #0
>    beq	earlier_than_label
> 
> Which was lost information to
> 
>    cmp	r0, #CPU_3XX_ES20
>    blt	earlier_than_label
> 
> The paths through the enable routine were verified by
> adding an infinite loop and seeing the hang.  Then
> removing the infinite loop and seeing it continue.
> 
> The disable routine is similar enough that it was not
> tested with this method.
> 
> Run tested by cold booting from nand on beagle and zoom1.
> Compile tested on MAKEALL arm.
for the l2 cache ACK
for the invalidate cache NACK

we do not need to call the rom code as the armv7 flush cache work fine
on omap3 and duplicate armv7 code with really few code (non needed) no

Best Regards,
J.

  parent reply	other threads:[~2009-08-12 21:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-12 15:42 [U-Boot] RE ARM Cortex8 Rename and move v7_flush_dcache_all to flush_dcache Tom Rix
2009-08-12 15:42 ` [U-Boot] [PATCH] OMAP3 Move cache routines to cache.S Tom Rix
2009-08-12 16:35   ` Dirk Behme
2009-08-12 21:13   ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2009-08-12 22:38     ` Tom
2009-08-12 21:49   ` Wolfgang Denk
2009-08-12 22:17     ` Tom
2009-09-10 23:39   ` Paulraj, Sandeep
2009-09-11  1:11     ` Tom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090812211316.GF21725@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox