public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] OMAP3 Move cache routines to cache.S
Date: Wed, 12 Aug 2009 23:49:41 +0200	[thread overview]
Message-ID: <20090812214941.A158D833DBD2@gemini.denx.de> (raw)
In-Reply-To: <1250091750-1525-2-git-send-email-Tom.Rix@windriver.com>

Dear Tom Rix,

In message <1250091750-1525-2-git-send-email-Tom.Rix@windriver.com> you wrote:
> v7_flush_dcache_all, because it depends on omap ROM code is not
> generic.  Rename the function to 'invalidate_dcache' and move it
> to the omap cpu directory.
> 
> Collect the other omap cache routines l2_cache_enable and
> l2_cache_disable with invalide_dcache into cache.S.  This
> means removing the old cache.c file that contained l2_cache_enable
> and l2_cache_disable.
> 
> The conversion from cache.c to cache.S was done most through
> disassembling the uboot binary.  The only significant change was
> to change the comparision for the return of get_cpu_rev from

May I ask what the motivation for this change was? Normally we try to
move as much code as possible to C, i. e. go the opposite way.

> The disable routine is similar enough that it was not
> tested with this method.
> 
> Run tested by cold booting from nand on beagle and zoom1.
> Compile tested on MAKEALL arm.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Do not underestimate the value of print statements for debugging.
Don't have aesthetic convulsions when using them, either.

  parent reply	other threads:[~2009-08-12 21:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-12 15:42 [U-Boot] RE ARM Cortex8 Rename and move v7_flush_dcache_all to flush_dcache Tom Rix
2009-08-12 15:42 ` [U-Boot] [PATCH] OMAP3 Move cache routines to cache.S Tom Rix
2009-08-12 16:35   ` Dirk Behme
2009-08-12 21:13   ` Jean-Christophe PLAGNIOL-VILLARD
2009-08-12 22:38     ` Tom
2009-08-12 21:49   ` Wolfgang Denk [this message]
2009-08-12 22:17     ` Tom
2009-09-10 23:39   ` Paulraj, Sandeep
2009-09-11  1:11     ` Tom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090812214941.A158D833DBD2@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox