public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net: sync env ethaddr to device enetaddr in eth_init()
Date: Thu, 13 Aug 2009 01:21:50 -0400	[thread overview]
Message-ID: <200908130121.52603.vapier@gentoo.org> (raw)
In-Reply-To: <4A79F91A.4060005@gmail.com>

On Wednesday 05 August 2009 17:26:50 Ben Warren wrote:
> Wolfgang Denk wrote:
> > Mike Frysinger wrote:
> >> In the previous enetaddr refactoring, the assumption with commit
> >> 56b555a644 was that the eth layer would handle the env -> device
> >> enetaddr syncing. This was not the case as eth_initialize() is called
> >> only once and the sync occurs there.  So make sure the eth_init()
> >> function does the env -> device sync with every network init.
> >>
> >> Reported-by: Andrzej Wolski <awolski@poczta.fm>
> >> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> >> ---
> >> Andrzej: please try this patch instead for your macb troubles
> >>
> >>  include/net.h |    2 +-
> >>  net/eth.c     |   52
> >> +++++++++++++++++++++++----------------------------- 2 files changed, 24
> >> insertions(+), 30 deletions(-)
> >
> > Ping...
>
> This came after the merge window closed, but appears to be a bug fix so
> I'll process tonight.

point of information: i'm pretty sure this was posted before the window 
closed.  dates:
 15 Jul 2009 - patch posted
 17 Jul 2009 - net summary posted
 19 Jul 2009 - merge window closed
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090813/6fb026dd/attachment.pgp 

  reply	other threads:[~2009-08-13  5:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-16  1:31 [U-Boot] [PATCH] net: sync env ethaddr to device enetaddr in eth_init() Mike Frysinger
2009-07-17 14:25 ` Andrzej Wolski
2009-08-05 21:24 ` Wolfgang Denk
2009-08-05 21:26   ` Ben Warren
2009-08-13  5:21     ` Mike Frysinger [this message]
2009-08-08  0:43 ` Ben Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200908130121.52603.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox