public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Add support to mkconfig for setting simple #defines in config.h
Date: Thu, 13 Aug 2009 16:23:50 -0400	[thread overview]
Message-ID: <200908131623.52013.vapier@gentoo.org> (raw)
In-Reply-To: <20090813201511.D439E833DBD2@gemini.denx.de>

On Thursday 13 August 2009 16:15:11 Wolfgang Denk wrote:
> Mike Frysinger wrote:
> > > Consider a target such as BOARDNAME_66MHz_NANDBOOT_PCISLAVE.
> > >
> > > It could then invoke "$(MKCONFIG) -D $@ -a configname arch cpu board".
> > > mkconfig would break up the -D argument into:
> > >
> > > #define CONFIG_BOARDNAME
> > > #define CONFIG_66MHz
> > > #define CONFIG_NANDBOOT
> > > #define CONFIG_PCISLAVE
> >
> > then yes, a sed would have to be used.  maybe something like:
> > DEFINES="`echo "_$*" | sed 's:_:\n#define CONFIG_:g'`${DEFINES}" ; shift
> > > ;;
>
> Nope, this doesn't work.
>
> We have many names with more than one underscore in it (all the
> CONFIG_CMD_* and CONFIG_SYS_* and CONFIG_BOOTP_* and ...).

i'm only giving POSIX compliant versions of proposed code.  the issue you 
raised i dont care about -- that's for the OP to handle.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090813/94a9ea16/attachment.pgp 

  reply	other threads:[~2009-08-13 20:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-07 14:03 [U-Boot] [PATCH] Add support to mkconfig for setting simple #defines in config.h Kumar Gala
2009-08-07 19:22 ` Scott Wood
2009-08-13  5:15   ` Mike Frysinger
2009-08-13 15:28     ` Scott Wood
2009-08-13 18:26       ` Mike Frysinger
2009-08-13 18:38         ` Scott Wood
2009-08-13 20:02           ` Mike Frysinger
2009-08-13 20:15             ` Wolfgang Denk
2009-08-13 20:23               ` Mike Frysinger [this message]
2009-08-13 22:01               ` Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200908131623.52013.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox