public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Fix all linker scripts for older binutils versions (pre-2.16)
Date: Mon, 17 Aug 2009 16:15:44 -0400	[thread overview]
Message-ID: <200908171615.45626.vapier@gentoo.org> (raw)
In-Reply-To: <20090817193130.2E2F6833DBD2@gemini.denx.de>

On Monday 17 August 2009 15:31:30 Wolfgang Denk wrote:
> Mike wrote:
> > > Mike, I am aware that Blackfin is already using the C preprocessor to
> > > generate it's linker scripts. I guess this step can now be folded into
> > > this general mechanism. Do you want to provide such a patch, or shall
> > > I do it?
> >
> > toolchains that are older than binutils-2.17 wont work with the Blackfin
> > port, so compatibility with pre-2.16 isnt something this port needs to
> > worry about
>
> Agreed, but the cpp step is now _always_ performed, and in your case
> twice - first in your board directory, and then again by the top level
> Makefile. You could save the local run now.

ok, i missed that aspect.  i think the changes needed are:

lib_blackfin/Makefile:
	-$(obj)u-boot.lds: u-boot.lds.S
	-   $(CPP) $(CPPFLAGS) -D__ASSEMBLY__ -P $^ > $@
lib_blackfin/config.mk:
	-LDSCRIPT = $(obj)lib_$(ARCH)/u-boot.lds
	+LDSCRIPT = $(obj)lib_$(ARCH)/u-boot.lds.S

i can post a patch once yours gets merged
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090817/05d6cb28/attachment.pgp 

  reply	other threads:[~2009-08-17 20:15 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-17 12:00 [U-Boot] [PATCH] Fix all linker scripts for older binutils versions (pre-2.16) Wolfgang Denk
2009-08-17 19:14 ` Mike Frysinger
2009-08-17 19:31   ` Wolfgang Denk
2009-08-17 20:15     ` Mike Frysinger [this message]
2009-08-17 20:24       ` Wolfgang Denk
2009-08-17 20:31         ` Mike Frysinger
2009-08-21 21:14 ` Wolfgang Denk
2009-08-22 23:50 ` [U-Boot] [PATCH] Blackfin: use common code to preprocess linker script Mike Frysinger
2009-08-23 20:25   ` Wolfgang Denk
2009-08-23  0:00 ` [U-Boot] [PATCH] Fix all linker scripts for older binutils versions (pre-2.16) Mike Frysinger
2009-08-23  5:34   ` Wolfgang Denk
2009-08-23  6:09     ` Mike Frysinger
2009-08-23 19:30       ` Wolfgang Denk
2009-08-23  6:47     ` [U-Boot] [PATCH] start a linker script helper file Mike Frysinger
2009-08-23 20:41       ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200908171615.45626.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox