[U-Boot] [PATCH 2/4]: Define ffs/fls for all architectures

Wolfgang Denk
2009-08-21T21:59:15Z

Dear Simon Kagstrom,

In message <20090820104212.48a033e2@marrow.netinsight.se> you wrote:
> On Thu, 20 Aug 2009 01:11:09 +0200
> Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> wrote:
>
> > On 11:13 Tue 18 Aug , Simon Kagstrom wrote:
> > > Define ffs/fls for all architectures
> > >
> > > UBIFS requires fls(), which is not defined for arm (and some other
> > > architectures) and this patch adds it. The implementation is taken from
> > > Linux and is generic. ffs() is also defined for those that miss it.
> > >
> > > v2: Unify code style (empty line between ffs/fls)
> > please this
> > >
> > > Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net>
> > > ---
> > here
>
> I didn't add that myself - it's git format-patch that put it there.

What Jean-Christophe means is: Please don't put comments like "v2:
Unify code style ..." in the area where the commit message is, but
move them into the comment section, i. e. below the "---" line.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
To be sure of hitting the target, shoot first and, whatever you hit,
call it the target.