public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] ARM Cortex8 Rename and move v7_flush_dcache_all to flush_dcache
Date: Thu, 20 Aug 2009 01:49:37 +0200	[thread overview]
Message-ID: <20090819234937.GM8470@game.jcrosoft.org> (raw)
In-Reply-To: <4A8048B4.80500@googlemail.com>

> >>>>>
> >>>>>Applying the basic functionality (function move) now allows others
> >>>>>to finally go on with their long waiting patches.
> >>>>no this code is omap3 specific and there is no need ot this
> >>>>rename or move the function make no sense
> >>>Yes, it is OMAP3 specific (as already mentioned in the patch
> >>>description). So it's totally fine to move it to an OMAP3 specific
> >>>file. So it's totally fine that others (!= OMAP3, e.g Samsung) can
> >>>re-use arm_cortexa8 stuff without the burden of OMAP3 stuff.
> >>the flush MUST NOT be soc specific as there is NO need to do this
> >>at all
> >>
> >>so NACK
> >
> >Let's summarize:
> >
> >- First, you NACK because of device_type and function name
> >- Then, you mention "this code is omap3 specific"
> >- Then, you mention "this code is not needed at all"
> >
> >Sorry, but this sounds somehow confusing, better let us stop here.
> >
> >As already mentioned, let us apply the patch so that other Cortex
> >A8 patches are not stalled any more.
> 
> At the weekend, I missed the point why this code is OMAP3 specific
> and why it has to be moved to omap3 directory, so short update:
> 
> It calls OMAP3 ROM code. This doesn't work on other Cortex A8, e.g.
> Samsung. That is, it must be moved to not stall others any more.
so I'll repeat this only once there no need to call the rom code as the
generic armv7 cache full work fine

so no-need to use omap3 specific code

Best Regards,
J.

  reply	other threads:[~2009-08-19 23:49 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-08 10:46 [U-Boot] [PATCH v2] ARM Cortex8 Rename and move v7_flush_dcache_all to flush_dcache Dirk Behme
2009-08-08 10:46 ` [U-Boot] [PATCH] OMAP3: Fix missing GPMC_CONFIG_CS0_BASE Dirk Behme
2009-08-09 22:13   ` Wolfgang Denk
2009-08-08 11:26 ` [U-Boot] [PATCH v2] ARM Cortex8 Rename and move v7_flush_dcache_all to flush_dcache Jean-Christophe PLAGNIOL-VILLARD
2009-08-08 13:47   ` Dirk Behme
2009-08-08 14:10     ` Jean-Christophe PLAGNIOL-VILLARD
2009-08-08 14:35       ` Dirk Behme
2009-08-08 15:00         ` Jean-Christophe PLAGNIOL-VILLARD
2009-08-08 15:18           ` Dirk Behme
2009-08-08 15:26             ` Jean-Christophe PLAGNIOL-VILLARD
2009-08-08 18:03               ` Wolfgang Denk
2009-08-08 18:59                 ` Jean-Christophe PLAGNIOL-VILLARD
2009-08-10 16:20             ` Dirk Behme
2009-08-19 23:49               ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2009-08-20 11:48                 ` Tom
2009-08-20 13:52                   ` Dirk Behme

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090819234937.GM8470@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox