From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Christophe PLAGNIOL-VILLARD Date: Thu, 20 Aug 2009 07:18:38 +0200 Subject: [U-Boot] [PATCH] Adding support for DevKit8000 In-Reply-To: References: <1250551204-15333-1-git-send-email-frederik@kriewitz.eu> <20090819221404.GA8470@game.jcrosoft.org> Message-ID: <20090820051838.GP8470@game.jcrosoft.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 05:59 Thu 20 Aug , Frederik Kriewitz wrote: > I'll fix that. > > On Thu, Aug 20, 2009 at 12:19 AM, Jean-Christophe > PLAGNIOL-VILLARD wrote: > >> +void reset_phy(void) > >> +{ > >> + ? ? eth_init(gd->bd); > >> +} > > NACK > > the net need to be init only when you use it > > The kernel will try to use the already (temporally) programmed MAC address. > I always init it because that way no kernel hack for the MAC address > is required. > Is it ok if I add a comment? no sorry this will be also nack by Wolfgang to program the mac you need to create a initramfs in your kernel wich generate the same thing or read the content of the U-Boot env via fw_printenv and use ifconfig hw ether Best Regards, J.