From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Thu, 20 Aug 2009 07:01:21 +0200 Subject: [U-Boot] NAND ECC Error with wrong SMC ording bug In-Reply-To: <20090820003851.1a532444@lappy.seanm.ca> References: <19081.57584.173693.798535@cargo.ozlabs.ibm.com> <4A8C87E6.6070702@amcc.com> <20090820003851.1a532444@lappy.seanm.ca> Message-ID: <200908200701.21076.sr@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thursday 20 August 2009 06:38:51 Sean MacLennan wrote: > > I see other boards using SMC as well, can someone comment on the > > change I am proposing. > > Should I change the correction algorithm or the calculate function? > > If the later is preferred > > it would mean the change must be pushed in both U-Boot and Linux. > > Odds are the calculate function is wrong. The correction algo is used > by many nand drivers, I *assume* it is correct. The calculate function > was set to agree with u-boot (1.3.0). Yes, it seems that you changed the order in the calculation function while reworking the NDFC driver for arch/powerpc. So we should probably change this order back to the original version. And change it in U-Boot as well. BTW: I didn't see any problems with ECC so far with the current code. Feng, how did you spot this problem? Cheers, Stefan -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de