From: Simon Kagstrom <simon.kagstrom@netinsight.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net: See to it that sent data is aligned to the ethernet controllers wishes
Date: Thu, 20 Aug 2009 08:25:59 +0200 [thread overview]
Message-ID: <20090820082559.3e71deb6@marrow.netinsight.se> (raw)
In-Reply-To: <4A8C2E92.50403@gmail.com>
On Wed, 19 Aug 2009 09:55:46 -0700
Ben Warren <biggerbadderben@gmail.com> wrote:
> My preference is for the drivers to handle alignment.
OK, I'm fine with that. I'd like to withdraw this patch then.
> I like Dave's idea of creating a buffer (or multiple buffers) in initialization(),
> then memcpy'ing to to it in the send() routine. You could make it smart
> to only memcpy if the frame is not aligned as needed.
It already only memcpys unaligned buffers, but I'll go with Daves
suggestion and allocate it at startup instead.
> Your original patch created a buffer of size 9000, which I commented was
> probably bigger than necessary. I didn't see a response to that (which
> doesn't mean you didn't send one, but I get a lot of e-mail :)
I was off for vacation [*], so I only sent it this week. I'll rework this
patch a bit to address a small bug I found.
Thanks for the comments!
// Simon
[*] By now the U-boot list is probably tired of hearing about my
vacation, but I can assure you that I had a good time!
prev parent reply other threads:[~2009-08-20 6:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-19 7:26 [U-Boot] [PATCH] net: See to it that sent data is aligned to the ethernet controllers wishes Simon Kagstrom
2009-08-19 7:36 ` Liu Dave-R63238
2009-08-19 7:51 ` Simon Kagstrom
2009-08-19 8:06 ` Liu Dave-R63238
2009-08-19 8:17 ` Simon Kagstrom
2009-08-19 16:55 ` Ben Warren
2009-08-20 6:25 ` Simon Kagstrom [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090820082559.3e71deb6@marrow.netinsight.se \
--to=simon.kagstrom@netinsight.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox