[U-Boot] [PATCH 1/3]: arm:kirkwood Define kirkwood phy address magic number

[Simon Kagstrom <simon.kagstrom@netinsight.net>]

On Thu, 20 Aug 2009 02:40:48 -0700
Prafulla Wadaskar <prafulla@marvell.com> wrote:

> >  
> > +#define KIRKWOOD_PHY_ADR_REQUEST 0xee
> define this in header file
> 
> Basically this is needed in drivers/net/phy/mv88e61xx.c for multi chip support
> in this case we need to define this in include/miiphy.h.
> which conflicts with other phy address definition, that's why not done earlier
> 
> It makes more sense to add APIs miiphy_read/write_phyadr to miiutils

But is this really general functionality? miiphy.h is something I
suppose should be generic between phys and not contain device-specific
things like this.

Perhaps we should revive the patches that move out the phy
initialization from sheevaplug.c and place the define and some
implementation there?

// Simon