From mboxrd@z Thu Jan  1 00:00:00 1970
From: Simon Kagstrom <simon.kagstrom@netinsight.net>
Date: Thu, 20 Aug 2009 13:47:07 +0200
Subject: [U-Boot] [PATCH 1/3]: arm:kirkwood Define kirkwood phy address
 magic number
In-Reply-To: <73173D32E9439E4ABB5151606C3E19E202E39159B4@SC-VEXCH1.marvell.com>
References: <20090820101228.220d16b2@marrow.netinsight.se>
	<73173D32E9439E4ABB5151606C3E19E202E39159B4@SC-VEXCH1.marvell.com>
Message-ID: <20090820134707.7ab2dbbb@marrow.netinsight.se>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Thu, 20 Aug 2009 02:40:48 -0700
Prafulla Wadaskar <prafulla@marvell.com> wrote:

> >  
> > +#define KIRKWOOD_PHY_ADR_REQUEST 0xee
> define this in header file
> 
> Basically this is needed in drivers/net/phy/mv88e61xx.c for multi chip support
> in this case we need to define this in include/miiphy.h.
> which conflicts with other phy address definition, that's why not done earlier
> 
> It makes more sense to add APIs miiphy_read/write_phyadr to miiutils

But is this really general functionality? miiphy.h is something I
suppose should be generic between phys and not contain device-specific
things like this.

Perhaps we should revive the patches that move out the phy
initialization from sheevaplug.c and place the define and some
implementation there?

// Simon