From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] driver/fsl_pci: Added fsl_pci_init_port function to initialize a single PCIe port.
Date: Thu, 20 Aug 2009 17:12:09 +0200 [thread overview]
Message-ID: <20090820151209.333D5833DBD2@gemini.denx.de> (raw)
In-Reply-To: <1250775038-20372-1-git-send-email-poonam.aggrwal@freescale.com>
Dear Poonam Aggrwal,
In message <1250775038-20372-1-git-send-email-poonam.aggrwal@freescale.com> you wrote:
> * Added a generic function fsl_pci_init_port in drivers/pci/fsl_pci.c
> to initialize a PCIe port.
> * fsl_pci_init_port can be called from board specific pcie initialization
> routine, per-port.
> * This will reduce the code redundancy in the most of the Freescale board
> specific PCIe inits.
>
> Signed-off-by: Poonam Aggrwal <poonam.aggrwal@freescale.com>
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> ---
NAK.
I see just dead code added, without any users.
If this gets used somewhere, this should be visible in the patch, and
lead to code removed somewhere?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You cannot propel yourself forward by patting yourself on the back.
next prev parent reply other threads:[~2009-08-20 15:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-20 13:30 [U-Boot] [PATCH] driver/fsl_pci: Added fsl_pci_init_port function to initialize a single PCIe port Poonam Aggrwal
2009-08-20 15:12 ` Wolfgang Denk [this message]
2009-08-20 15:24 ` Kumar Gala
2009-08-20 15:38 ` Aggrwal Poonam-B10812
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090820151209.333D5833DBD2@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox