From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wolfgang Denk <wd@denx.de>
Date: Thu, 20 Aug 2009 17:14:59 +0200
Subject: [U-Boot] [PATCH] ppc/85xx: Added PCIe support for P1 P2 RDB
In-Reply-To: <1250775054-20418-1-git-send-email-poonam.aggrwal@freescale.com>
References: <1250775054-20418-1-git-send-email-poonam.aggrwal@freescale.com>
Message-ID: <20090820151459.C01F3833DBD2@gemini.denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Poonam Aggrwal,

In message <1250775054-20418-1-git-send-email-poonam.aggrwal@freescale.com> you wrote:
> * Added PCIe support for P1 P2 RDB
> * Calls the fsl_pci_init_port function to initialize all the PCIe ports
>   on the board.
> 
> Signed-off-by: Poonam Aggrwal <poonam.aggrwal@freescale.com>
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> ---
> - applies on git.denx.de/u-boot-mpc85xx.git branch->next
>  board/freescale/p1_p2_rdb/Makefile |    1 +
>  board/freescale/p1_p2_rdb/pci.c    |  112 ++++++++++++++++++++++++++++++++++++
>  include/configs/P1_P2_RDB.h        |    6 ++
>  3 files changed, 119 insertions(+), 0 deletions(-)
>  create mode 100644 board/freescale/p1_p2_rdb/pci.c
> 
> diff --git a/board/freescale/p1_p2_rdb/Makefile b/board/freescale/p1_p2_rdb/Makefile
> index 9107263..c366f7c 100644
> --- a/board/freescale/p1_p2_rdb/Makefile
> +++ b/board/freescale/p1_p2_rdb/Makefile
> @@ -27,6 +27,7 @@ LIB	= $(obj)lib$(BOARD).a
>  COBJS-y	+= $(BOARD).o
>  COBJS-y	+= law.o
>  COBJS-y	+= tlb.o
> +COBJS-$(CONFIG_PCI)  += pci.o
>  COBJS-y	+= ddr.o

Please (make and) keep list sorted.

...
> +void ft_pci_board_setup(void *blob)
> +{
> +#ifdef CONFIG_PCIE2
> +	ft_fsl_pci_setup(blob, "pci1", &pcie2_hose);

PCIE2 ... pci1 ... pcie2 ???

> +#endif
> +#ifdef CONFIG_PCIE1
> +	ft_fsl_pci_setup(blob, "pci2", &pcie1_hose);

PCIE1 ... pci2 ... pcie1 ???

This looks broken to me?


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
As far as the laws of mathematics refer to reality, they are not cer-
tain, and as far as they are certain, they do not refer  to  reality.
                                                   -- Albert Einstein