From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Fri, 21 Aug 2009 02:29:30 -0400 Subject: [U-Boot] [PATCH v2 1/4]: Move __set/clear_bit from ubifs.h to bitops.h In-Reply-To: <20090821080547.22c8d94d@marrow.netinsight.se> References: <20090820104944.42dbeca7@marrow.netinsight.se> <200908201344.37190.vapier@gentoo.org> <20090821080547.22c8d94d@marrow.netinsight.se> Message-ID: <200908210229.31408.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Friday 21 August 2009 02:05:47 Simon Kagstrom wrote: > On Thu, 20 Aug 2009 13:44:35 -0400 Mike Frysinger wrote: > > On Thursday 20 August 2009 04:52:50 Simon Kagstrom wrote: > > > --- a/include/asm-sh/bitops.h > > > +++ b/include/asm-sh/bitops.h > > > @@ -146,6 +146,11 @@ static inline int ffs (int x) > > > } > > > return r; > > > } > > > + > > > +#define __set_bit(nr, addr) generic_set_bit(nr, addr) > > > + > > > +#define __clear_bit(nr, addr) generic_clear_bit(nr, addr) > > > > this is just silly to put into every arch header. why not do in the > > common code: > > #ifndef __set_bit > > # define __set_bit generice_set_bit > > #endif > > It's a function (static inline) in some architectures. add the obvious #define i already posted in a later e-mail. it makes a lot more sense for the non-common behavior of providing a custom implementation to add one more line per func than to try and update (and keep up-to-date) every arch using the common code. -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20090821/4c546506/attachment.pgp