From mboxrd@z Thu Jan  1 00:00:00 1970
From: Simon Kagstrom <simon.kagstrom@netinsight.net>
Date: Fri, 21 Aug 2009 09:03:39 +0200
Subject: [U-Boot] [PATCH v2 1/4]: Move __set/clear_bit from ubifs.h to
 bitops.h
In-Reply-To: <200908210229.31408.vapier@gentoo.org>
References: <20090820104944.42dbeca7@marrow.netinsight.se>
	<200908201344.37190.vapier@gentoo.org>
	<20090821080547.22c8d94d@marrow.netinsight.se>
	<200908210229.31408.vapier@gentoo.org>
Message-ID: <20090821090339.3e7eda76@marrow.netinsight.se>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Fri, 21 Aug 2009 02:29:30 -0400
Mike Frysinger <vapier@gentoo.org> wrote:

> > > this is just silly to put into every arch header.  why not do in the
> > > common code:
> > > #ifndef __set_bit
> > > # define __set_bit generice_set_bit
> > > #endif
> >
> > It's a function (static inline) in some architectures.
> 
> add the obvious #define i already posted in a later e-mail.  it makes a lot 
> more sense for the non-common behavior of providing a custom implementation to 
> add one more line per func than to try and update (and keep up-to-date) every 
> arch using the common code.

Yep, I saw your mail too late. I'll rework the patch series and resubmit.

// Simon