From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/4]: Define ffs/fls for all architectures
Date: Fri, 21 Aug 2009 23:59:15 +0200 [thread overview]
Message-ID: <20090821215915.BB481833DBD2@gemini.denx.de> (raw)
In-Reply-To: <20090820104212.48a033e2@marrow.netinsight.se>
Dear Simon Kagstrom,
In message <20090820104212.48a033e2@marrow.netinsight.se> you wrote:
> On Thu, 20 Aug 2009 01:11:09 +0200
> Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> wrote:
>
> > On 11:13 Tue 18 Aug , Simon Kagstrom wrote:
> > > Define ffs/fls for all architectures
> > >
> > > UBIFS requires fls(), which is not defined for arm (and some other
> > > architectures) and this patch adds it. The implementation is taken from
> > > Linux and is generic. ffs() is also defined for those that miss it.
> > >
> > > v2: Unify code style (empty line between ffs/fls)
> > please this
> > >
> > > Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net>
> > > ---
> > here
>
> I didn't add that myself - it's git format-patch that put it there.
What Jean-Christophe means is: Please don't put comments like "v2:
Unify code style ..." in the area where the commit message is, but
move them into the comment section, i. e. below the "---" line.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
To be sure of hitting the target, shoot first and, whatever you hit,
call it the target.
next prev parent reply other threads:[~2009-08-21 21:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-18 9:08 [U-Boot] [PATCH 0/4]: bitops cleanup and fixes Simon Kagstrom
2009-08-18 9:10 ` [U-Boot] [PATCH 1/4]: Move __set/clear_bit from ubifs.h to bitops.h Simon Kagstrom
2009-08-19 23:12 ` Jean-Christophe PLAGNIOL-VILLARD
2009-08-18 9:13 ` [U-Boot] [PATCH 2/4]: Define ffs/fls for all architectures Simon Kagstrom
2009-08-19 23:11 ` Jean-Christophe PLAGNIOL-VILLARD
2009-08-20 8:42 ` Simon Kagstrom
2009-08-21 21:59 ` Wolfgang Denk [this message]
2009-08-18 9:13 ` [U-Boot] [PATCH 3/4]: Remove duplicate set_cr Simon Kagstrom
2009-08-19 23:06 ` Jean-Christophe PLAGNIOL-VILLARD
2009-08-18 9:14 ` [U-Boot] [PATCH 4/4]: Define test_and_set_bit and test_and_clear bit for ARM Simon Kagstrom
2009-08-19 23:15 ` Jean-Christophe PLAGNIOL-VILLARD
2009-08-19 22:56 ` [U-Boot] [PATCH 0/4]: bitops cleanup and fixes Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090821215915.BB481833DBD2@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox