public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Fix all linker scripts for older binutils versions (pre-2.16)
Date: Sun, 23 Aug 2009 21:30:47 +0200	[thread overview]
Message-ID: <20090823193047.B35FD833DBD2@gemini.denx.de> (raw)
In-Reply-To: <200908230209.10484.vapier@gentoo.org>

Dear Mike Frysinger,

In message <200908230209.10484.vapier@gentoo.org> you wrote:
>
> > > this check will fail with binutils 3.0+ because of the minor check for 16
> > > without a corresponding major check.
> >
> > Well, the "\1 -lt 2" is the major check, isn't it?
>
> here is how the shell code looks:
> [ $major -lt 2 ] || [ $minor -lt 16 ] && echo old_ld

Oops.

> and the way shell logic works, the echo is executed if either of those tests 
> fail.  what you really wanted was:
> [ $major -lt 2 ] || [ $major -eq 2 -a $minor -lt 16 ] && echo old_ld

Right you are. Silly me.

Thanks for catching this in time.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
In general, they do what you want, unless you want consistency.
                                    - Larry Wall in the perl man page

  reply	other threads:[~2009-08-23 19:30 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-17 12:00 [U-Boot] [PATCH] Fix all linker scripts for older binutils versions (pre-2.16) Wolfgang Denk
2009-08-17 19:14 ` Mike Frysinger
2009-08-17 19:31   ` Wolfgang Denk
2009-08-17 20:15     ` Mike Frysinger
2009-08-17 20:24       ` Wolfgang Denk
2009-08-17 20:31         ` Mike Frysinger
2009-08-21 21:14 ` Wolfgang Denk
2009-08-22 23:50 ` [U-Boot] [PATCH] Blackfin: use common code to preprocess linker script Mike Frysinger
2009-08-23 20:25   ` Wolfgang Denk
2009-08-23  0:00 ` [U-Boot] [PATCH] Fix all linker scripts for older binutils versions (pre-2.16) Mike Frysinger
2009-08-23  5:34   ` Wolfgang Denk
2009-08-23  6:09     ` Mike Frysinger
2009-08-23 19:30       ` Wolfgang Denk [this message]
2009-08-23  6:47     ` [U-Boot] [PATCH] start a linker script helper file Mike Frysinger
2009-08-23 20:41       ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090823193047.B35FD833DBD2@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox