public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] ppc4xx: Rename compactcenter to intip
Date: Wed, 26 Aug 2009 09:08:26 +0200	[thread overview]
Message-ID: <200908260908.26926.sr@denx.de> (raw)
In-Reply-To: <1250842401-7591-1-git-send-email-eibach@gdsys.de>

Hi Dirk,

On Friday 21 August 2009 10:13:21 Dirk Eibach wrote:
> Signed-off-by: Dirk Eibach <eibach@gdsys.de>
> ---
> Changes since v1:
> - also changed config name
>
>  Makefile                        |   16 ++++++++--------
>  include/configs/compactcenter.h |    6 +++---
>  2 files changed, 11 insertions(+), 11 deletions(-)

I just noticed that when changing the config name, you also need to change 
this in MAKEALL and MAINTAINERS. And thinking further about it, you are now 
removing the target name "compactcenter", but you keep the files 
"compactcenter.h" and the board directory "board/gdsys/compactcenter". This 
seems inconsistent to me.

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de

  reply	other threads:[~2009-08-26  7:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-21  8:13 [U-Boot] [PATCH v2] ppc4xx: Rename compactcenter to intip Dirk Eibach
2009-08-26  7:08 ` Stefan Roese [this message]
2009-09-08  7:53   ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200908260908.26926.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox