[U-Boot] [RFC PATCH 1/3] net: rework the mii support

[Mike Frysinger <vapier@gentoo.org>]

On Wednesday 26 August 2009 16:13:01 Jean-Christophe PLAGNIOL-VILLARD wrote:
> this rework is done in order to add a phylib and reduce and simplify
> the implementation of multi net_device support for the same driver

i think you mean multi phy ...

> precedently we pass the device name to the miiphy_read/write & co

while the first word could be used, i think you mean "presently"

> now we pass the mii_device instance of the mii bus
> all network driver are switch to this way

if you're going to avoid punctuation in your commits, then separate sentences 
really need separate paragraphs

and the second sentence probably should be "drivers are converted to this 
method"

> we currently keep the old miiphy api by wrapping it to the new mii_device
> api until we have the phylib implementation and all the network driver
> using it

if the old method and header is deprecated, then you could add a #warning to 
the old header telling people to change

the changes to the Blackfin MAC driver looks sane to me, thanks
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090826/eaef0b49/attachment.pgp