From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Thu, 27 Aug 2009 07:11:32 +0200 Subject: [U-Boot] [RFC PATCH 2/3] net: add phylib implementation In-Reply-To: <200908262155.58509.vapier@gentoo.org> References: <4A938C76.9000009@monstr.eu> <1251317583-27875-2-git-send-email-plagnioj@jcrosoft.com> <200908262155.58509.vapier@gentoo.org> Message-ID: <200908270711.32266.sr@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thursday 27 August 2009 03:55:57 Mike Frysinger wrote: > > +int phy_init(void) > > +{ > > + /* Initialize the list */ > > + INIT_LIST_HEAD(&phy_drvs.list); > > does it really need to be dynamic ? arent there static initializers so > this can be done in .data ? Using static initializers fails on PPC because of the somewhat broken relocation. So this dynamic implementation is the preferred version, at least for PPC people. Cheers, Stefan -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de