From: Eric Millbrandt <emillbrandt@coldhaus.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Add chip select region to galaxy5200
Date: Fri, 28 Aug 2009 07:02:27 -0500 [thread overview]
Message-ID: <20090828120027.M71105@coldhaus.com> (raw)
In-Reply-To: <fa686aa40908271646j1d994919j729336eafa16cd42@mail.gmail.com>
On Thu, 27 Aug 2009 17:46:03 -0600, Grant Likely wrote
> On Thu, Aug 27, 2009 at 4:11 PM, Eric
> Millbrandt<emillbrandt@coldhaus.com> wrote:
> > Add chip select region for an Epson S1D15313.
> >
> > Signed-off-by: Eric Millbrandt <emillbrandt@dekaresearch.com>
> > ---
> > ?include/configs/galaxy5200.h | ? ?5 +++++
> > ?1 files changed, 5 insertions(+), 0 deletions(-)
> >
> > diff --git a/include/configs/galaxy5200.h b/include/configs/galaxy5200.h
> > index eb2cae6..54c6b80 100644
> > --- a/include/configs/galaxy5200.h
> > +++ b/include/configs/galaxy5200.h
> > @@ -212,6 +212,11 @@
> > ?#define CONFIG_SYS_CS1_SIZE ? ? ? ? ? ?0x90000
> > ?#define CONFIG_SYS_CS1_CFG ? ? ? ? ? ? 0x0002d900
> >
> > +/* Chip Select configuration for Epson S1D13513 */
> > +#define CONFIG_SYS_CS3_START ? ? ? ? ? 0x10000000
> > +#define CONFIG_SYS_CS3_SIZE ? ? ? ? ? ?0x103fffff
> > +#define CONFIG_SYS_CS3_CFG ? ? ? ? ? ? 0xffff3d10
>
> This doesn't look right. Shouldn't CONFIG_SYS_CS3_SIZE be 0x00400000?
> (Compare with SYS_CS1 above)
>
Yes, you are correct. I must have been thinking of the STOP location instead
of the size of the region.
next prev parent reply other threads:[~2009-08-28 12:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-27 22:11 [U-Boot] [PATCH] Add chip select region to galaxy5200 Eric Millbrandt
2009-08-27 23:46 ` Grant Likely
2009-08-28 12:02 ` Eric Millbrandt [this message]
2009-08-28 10:39 ` Detlev Zundel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090828120027.M71105@coldhaus.com \
--to=emillbrandt@coldhaus.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox