public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] Add chip select region to galaxy5200
@ 2009-08-27 22:11 Eric Millbrandt
  2009-08-27 23:46 ` Grant Likely
  2009-08-28 10:39 ` Detlev Zundel
  0 siblings, 2 replies; 4+ messages in thread
From: Eric Millbrandt @ 2009-08-27 22:11 UTC (permalink / raw)
  To: u-boot

Add chip select region for an Epson S1D15313.

Signed-off-by: Eric Millbrandt <emillbrandt@dekaresearch.com>
---
 include/configs/galaxy5200.h |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/include/configs/galaxy5200.h b/include/configs/galaxy5200.h
index eb2cae6..54c6b80 100644
--- a/include/configs/galaxy5200.h
+++ b/include/configs/galaxy5200.h
@@ -212,6 +212,11 @@
 #define CONFIG_SYS_CS1_SIZE		0x90000
 #define CONFIG_SYS_CS1_CFG		0x0002d900
 
+/* Chip Select configuration for Epson S1D13513 */
+#define CONFIG_SYS_CS3_START		0x10000000
+#define CONFIG_SYS_CS3_SIZE		0x103fffff
+#define CONFIG_SYS_CS3_CFG		0xffff3d10
+
 /*
  * Ethernet configuration
  */
-- 
1.6.3.1


http://openwebmail.org - eem

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] Add chip select region to galaxy5200
  2009-08-27 22:11 [U-Boot] [PATCH] Add chip select region to galaxy5200 Eric Millbrandt
@ 2009-08-27 23:46 ` Grant Likely
  2009-08-28 12:02   ` Eric Millbrandt
  2009-08-28 10:39 ` Detlev Zundel
  1 sibling, 1 reply; 4+ messages in thread
From: Grant Likely @ 2009-08-27 23:46 UTC (permalink / raw)
  To: u-boot

On Thu, Aug 27, 2009 at 4:11 PM, Eric
Millbrandt<emillbrandt@coldhaus.com> wrote:
> Add chip select region for an Epson S1D15313.
>
> Signed-off-by: Eric Millbrandt <emillbrandt@dekaresearch.com>
> ---
> ?include/configs/galaxy5200.h | ? ?5 +++++
> ?1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/include/configs/galaxy5200.h b/include/configs/galaxy5200.h
> index eb2cae6..54c6b80 100644
> --- a/include/configs/galaxy5200.h
> +++ b/include/configs/galaxy5200.h
> @@ -212,6 +212,11 @@
> ?#define CONFIG_SYS_CS1_SIZE ? ? ? ? ? ?0x90000
> ?#define CONFIG_SYS_CS1_CFG ? ? ? ? ? ? 0x0002d900
>
> +/* Chip Select configuration for Epson S1D13513 */
> +#define CONFIG_SYS_CS3_START ? ? ? ? ? 0x10000000
> +#define CONFIG_SYS_CS3_SIZE ? ? ? ? ? ?0x103fffff
> +#define CONFIG_SYS_CS3_CFG ? ? ? ? ? ? 0xffff3d10

This doesn't look right.  Shouldn't CONFIG_SYS_CS3_SIZE be 0x00400000?
(Compare with SYS_CS1 above)

g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] Add chip select region to galaxy5200
  2009-08-27 22:11 [U-Boot] [PATCH] Add chip select region to galaxy5200 Eric Millbrandt
  2009-08-27 23:46 ` Grant Likely
@ 2009-08-28 10:39 ` Detlev Zundel
  1 sibling, 0 replies; 4+ messages in thread
From: Detlev Zundel @ 2009-08-28 10:39 UTC (permalink / raw)
  To: u-boot

Hi Eric,

in case you didn't notice, you misspelled Grants email
"grant.likely at secretlib.ca", while it should read
"grant.likely at secretlab.ca".  But hey, maybe he's also working on secret
libs that we don't know about *lol*

Cheers
  Detlev

-- 
Alisa Sherer (AMD) suggested that consumer demand will not follow
faster clock speeds. Marketing might help with this problem, she
added.                                            -- 2004/02/20
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] Add chip select region to galaxy5200
  2009-08-27 23:46 ` Grant Likely
@ 2009-08-28 12:02   ` Eric Millbrandt
  0 siblings, 0 replies; 4+ messages in thread
From: Eric Millbrandt @ 2009-08-28 12:02 UTC (permalink / raw)
  To: u-boot

On Thu, 27 Aug 2009 17:46:03 -0600, Grant Likely wrote
> On Thu, Aug 27, 2009 at 4:11 PM, Eric
> Millbrandt<emillbrandt@coldhaus.com> wrote:
> > Add chip select region for an Epson S1D15313.
> >
> > Signed-off-by: Eric Millbrandt <emillbrandt@dekaresearch.com>
> > ---
> > ?include/configs/galaxy5200.h | ? ?5 +++++
> > ?1 files changed, 5 insertions(+), 0 deletions(-)
> >
> > diff --git a/include/configs/galaxy5200.h b/include/configs/galaxy5200.h
> > index eb2cae6..54c6b80 100644
> > --- a/include/configs/galaxy5200.h
> > +++ b/include/configs/galaxy5200.h
> > @@ -212,6 +212,11 @@
> > ?#define CONFIG_SYS_CS1_SIZE ? ? ? ? ? ?0x90000
> > ?#define CONFIG_SYS_CS1_CFG ? ? ? ? ? ? 0x0002d900
> >
> > +/* Chip Select configuration for Epson S1D13513 */
> > +#define CONFIG_SYS_CS3_START ? ? ? ? ? 0x10000000
> > +#define CONFIG_SYS_CS3_SIZE ? ? ? ? ? ?0x103fffff
> > +#define CONFIG_SYS_CS3_CFG ? ? ? ? ? ? 0xffff3d10
> 
> This doesn't look right.  Shouldn't CONFIG_SYS_CS3_SIZE be 0x00400000?
> (Compare with SYS_CS1 above)
> 
Yes, you are correct.  I must have been thinking of the STOP location instead
of the size of the region.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2009-08-28 12:02 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-27 22:11 [U-Boot] [PATCH] Add chip select region to galaxy5200 Eric Millbrandt
2009-08-27 23:46 ` Grant Likely
2009-08-28 12:02   ` Eric Millbrandt
2009-08-28 10:39 ` Detlev Zundel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox