From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] Move uninitialized_var() macro from ubi_uboot.h to compiler.h
Date: Tue, 1 Sep 2009 22:25:18 +0400 [thread overview]
Message-ID: <20090901182518.GA17903@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <20090901181141.2D46F834A950@gemini.denx.de>
On Tue, Sep 01, 2009 at 08:11:41PM +0200, Wolfgang Denk wrote:
> Dear Anton Vorontsov,
>
> In message <20090901165803.GA3668@oksana.dev.rtsoft.ru> you wrote:
> > This is needed so that we could use this macro for non-UBI code.
> >
> > Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> > ---
> > include/compiler.h | 3 +++
> > include/ubi_uboot.h | 4 +---
> > 2 files changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/include/compiler.h b/include/compiler.h
> > index 272fd3c..e602cce 100644
> > --- a/include/compiler.h
> > +++ b/include/compiler.h
> > @@ -122,4 +122,7 @@ typedef unsigned int uintptr_t;
> >
> > #endif
> >
> > +/* compiler options */
> > +#define uninitialized_var(x) x = x
>
> Please excuse my ignorance, but where and what for is such a
> definition useful?
It's used to avoid GCC warnings, i.e. when GCC isn't smart enough
to see that some variable isn't actually used uninitialized.
~/linux-2.6$ git grep uninitialized_var drivers/ | wc -l
94
We can fix the warnings by assigning some value to a variable
at declaration, but the advantage of 'x = x' trick is that it
doesn't generate any code.
Thanks,
--
Anton Vorontsov
email: cbouatmailru at gmail.com
irc://irc.freenode.net/bd2
next prev parent reply other threads:[~2009-09-01 18:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-01 16:58 [U-Boot] [PATCH 1/2] Move uninitialized_var() macro from ubi_uboot.h to compiler.h Anton Vorontsov
2009-09-01 18:11 ` Wolfgang Denk
2009-09-01 18:25 ` Anton Vorontsov [this message]
2009-09-01 18:52 ` Albin Tonnerre
2009-09-01 19:58 ` Anton Vorontsov
2009-09-02 3:13 ` Mike Frysinger
2009-09-01 19:27 ` Wolfgang Denk
2009-09-01 22:17 ` [U-Boot] [PATCH v2] fsl: sys_eeprom: Fix 'may be used uninitialized' warning Anton Vorontsov
2009-09-01 22:43 ` Timur Tabi
2009-09-02 1:52 ` Kumar Gala
2009-09-04 20:16 ` [U-Boot] [PATCH 1/2] Move uninitialized_var() macro from ubi_uboot.h to compiler.h Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090901182518.GA17903@oksana.dev.rtsoft.ru \
--to=avorontsov@ru.mvista.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox