public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 8/8] OMAP3 zoom2 Use usbtty if the debug board is not connected.
Date: Sat, 5 Sep 2009 02:30:37 +0200	[thread overview]
Message-ID: <20090905003037.GD30118@game.jcrosoft.org> (raw)
In-Reply-To: <1252095170-5492-8-git-send-email-Tom.Rix@windriver.com>

On 15:12 Fri 04 Sep     , Tom Rix wrote:
> The preferred serial output comes from the debug board.
> When the debug board is disconnected, fall back on using
> usbtty from the usb connector on the Zoom2 board.
> 
> This shows up as /dev/ttyACM0 in a linux host.
> 
> Signed-off-by: Tom Rix <Tom.Rix@windriver.com>
> ---
>  board/omap3/zoom2/zoom2_serial.c |   16 ++++++++++++++++
>  include/configs/omap3_zoom2.h    |   17 +++++++++++++++++
>  2 files changed, 33 insertions(+), 0 deletions(-)
> 
> diff --git a/board/omap3/zoom2/zoom2_serial.c b/board/omap3/zoom2/zoom2_serial.c
> index a3d777d..434696a 100644
> --- a/board/omap3/zoom2/zoom2_serial.c
> +++ b/board/omap3/zoom2/zoom2_serial.c
> @@ -87,6 +87,10 @@ void quad_putc_dev (unsigned long base, const char c)
>  
>  		NS16550_putc ((NS16550_t) base, c);
>  	}
> +#ifdef CONFIG_USB_TTY
why not do this
#ifndef CONFIG_USB_TTY
#define	usbtty_putc(c)
#define	usbtty_puts(s)
#define usbtty_getc()	0
#define usbtty_tstc()	0
#endif

and then avoid the ifdef

Best Regards,
J.

  reply	other threads:[~2009-09-05  0:30 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-04 20:12 [U-Boot] [PATCH 1/8] USB Consolidate descriptor definitions Tom Rix
2009-09-04 20:12 ` [U-Boot] [PATCH 2/8] USB add macros for debugging usb device setup Tom Rix
2009-09-04 20:12   ` [U-Boot] [PATCH 3/8] TWL4030 Add usb PHY support Tom Rix
2009-09-04 20:12     ` [U-Boot] [PATCH 4/8] OMAP3 Add usb device support Tom Rix
2009-09-04 20:12       ` [U-Boot] [PATCH 5/8] OMAP3 zoom1 Add usbtty configuration Tom Rix
2009-09-04 20:12         ` [U-Boot] [PATCH 6/8] OMAP3 beagle " Tom Rix
2009-09-04 20:12           ` [U-Boot] [PATCH 7/8] USBTTY make some function declarations easier to use Tom Rix
2009-09-04 20:12             ` [U-Boot] [PATCH 8/8] OMAP3 zoom2 Use usbtty if the debug board is not connected Tom Rix
2009-09-05  0:30               ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2009-09-06 13:21                 ` Tom
2009-09-05  0:26           ` [U-Boot] [PATCH 6/8] OMAP3 beagle Add usbtty configuration Jean-Christophe PLAGNIOL-VILLARD
2009-09-05  0:26         ` [U-Boot] [PATCH 5/8] OMAP3 zoom1 " Jean-Christophe PLAGNIOL-VILLARD
2009-09-05  0:25       ` [U-Boot] [PATCH 4/8] OMAP3 Add usb device support Jean-Christophe PLAGNIOL-VILLARD
2009-09-06 13:35         ` Tom
2009-09-06 13:48           ` Jean-Christophe PLAGNIOL-VILLARD
2009-09-05  0:02     ` [U-Boot] [PATCH 3/8] TWL4030 Add usb PHY support Jean-Christophe PLAGNIOL-VILLARD
2009-09-06 13:46       ` Tom
2009-09-06 14:58         ` Jean-Christophe PLAGNIOL-VILLARD
2009-09-05  0:31   ` [U-Boot] [PATCH 2/8] USB add macros for debugging usb device setup Jean-Christophe PLAGNIOL-VILLARD
2009-09-06 13:19     ` Tom
  -- strict thread matches above, loose matches on Subject: below --
2009-09-28 16:34 [U-Boot] V2 of OMAP3 USB device Support y at windriver.com
2009-09-28 16:34 ` [U-Boot] [PATCH 1/8] USB Consolidate descriptor definitions y at windriver.com
2009-09-28 16:34   ` [U-Boot] [PATCH 2/8] USB add macros for debugging usb device setup y at windriver.com
2009-09-28 16:34     ` [U-Boot] [PATCH 3/8] TWL4030 Add usb PHY support y at windriver.com
2009-09-28 16:34       ` [U-Boot] [PATCH 4/8] OMAP3 Add usb device support y at windriver.com
2009-09-28 16:35         ` [U-Boot] [PATCH 5/8] OMAP3 zoom1 Add usbtty configuration y at windriver.com
2009-09-28 16:35           ` [U-Boot] [PATCH 6/8] OMAP3 beagle " y at windriver.com
2009-09-28 16:35             ` [U-Boot] [PATCH 7/8] USBTTY make some function declarations easier to use y at windriver.com
2009-09-28 16:35               ` [U-Boot] [PATCH 8/8] OMAP3 zoom2 Use usbtty if the debug board is not connected y at windriver.com
2009-09-28 16:37 [U-Boot] V2 of OMAP3 USB device Support Tom Rix
2009-09-28 16:37 ` [U-Boot] [PATCH 1/8] USB Consolidate descriptor definitions Tom Rix
2009-09-28 16:37   ` [U-Boot] [PATCH 2/8] USB add macros for debugging usb device setup Tom Rix
2009-09-28 16:37     ` [U-Boot] [PATCH 3/8] TWL4030 Add usb PHY support Tom Rix
2009-09-28 16:37       ` [U-Boot] [PATCH 4/8] OMAP3 Add usb device support Tom Rix
2009-09-28 16:37         ` [U-Boot] [PATCH 5/8] OMAP3 zoom1 Add usbtty configuration Tom Rix
2009-09-28 16:37           ` [U-Boot] [PATCH 6/8] OMAP3 beagle " Tom Rix
2009-09-28 16:37             ` [U-Boot] [PATCH 7/8] USBTTY make some function declarations easier to use Tom Rix
2009-09-28 16:37               ` [U-Boot] [PATCH 8/8] OMAP3 zoom2 Use usbtty if the debug board is not connected Tom Rix

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090905003037.GD30118@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox