[U-Boot] [PATCH v2] ppc4xx: Rename compactcenter to intip

[U-Boot] [PATCH v2] ppc4xx: Rename compactcenter to intip

[Dirk Eibach]

Signed-off-by: Dirk Eibach <eibach@gdsys.de>
---
Changes since v1:
- also changed config name

 Makefile                        |   16 ++++++++--------
 include/configs/compactcenter.h |    6 +++---
 2 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/Makefile b/Makefile
index 329e0f5..252d9d0 100644
--- a/Makefile
+++ b/Makefile
@@ -1283,14 +1283,6 @@ CATcenter_33_config:	unconfig
 CMS700_config:	unconfig
 	@$(MKCONFIG) $(@:_config=) ppc ppc4xx cms700 esd
 
-# Compact-Center & DevCon-Center use different U-Boot images
-compactcenter_config \
-devconcenter_config:	unconfig
-	@mkdir -p $(obj)include
-	@echo "#define CONFIG_$$(echo $(subst ,,$(@:_config=)) | \
-		tr '[:lower:]' '[:upper:]')" >$(obj)include/config.h
-	@$(MKCONFIG) -n $@ -a compactcenter ppc ppc4xx compactcenter gdsys
-
 CPCI2DP_config:	unconfig
 	@$(MKCONFIG) $(@:_config=) ppc ppc4xx cpci2dp esd
 
@@ -1375,6 +1367,14 @@ HH405_config:	unconfig
 HUB405_config:	unconfig
 	@$(MKCONFIG) $(@:_config=) ppc ppc4xx hub405 esd
 
+# Compact-Center(codename intip) & DevCon-Center use different U-Boot images
+intip_config \
+devconcenter_config:	unconfig
+	@mkdir -p $(obj)include
+	@echo "#define CONFIG_$$(echo $(subst ,,$(@:_config=)) | \
+		tr '[:lower:]' '[:upper:]')" >$(obj)include/config.h
+	@$(MKCONFIG) -n $@ -a compactcenter ppc ppc4xx compactcenter gdsys
+
 JSE_config:	unconfig
 	@$(MKCONFIG) $(@:_config=) ppc ppc4xx jse
 
diff --git a/include/configs/compactcenter.h b/include/configs/compactcenter.h
index f8a1bbb..bfdcd4f 100644
--- a/include/configs/compactcenter.h
+++ b/include/configs/compactcenter.h
@@ -32,15 +32,15 @@
  * High Level Configuration Options
  */
 /*
- * This config file is used for CompactCenter and DevCon-Center
+ * This config file is used for CompactCenter(codename intip) and DevCon-Center
  */
 #define CONFIG_460EX		1	/* Specific PPC460EX		*/
 #ifdef CONFIG_DEVCONCENTER
 #define CONFIG_HOSTNAME		devconcenter
 #define CONFIG_IDENT_STRING	" devconcenter 0.02"
 #else
-#define CONFIG_HOSTNAME		compactcenter
-#define CONFIG_IDENT_STRING	" compactcenter 0.02"
+#define CONFIG_HOSTNAME		intip
+#define CONFIG_IDENT_STRING	" intip 0.02"
 #endif
 #define CONFIG_440		1
 #define CONFIG_4xx		1	/* ... PPC4xx family */
-- 
1.5.6.5

[U-Boot] [PATCH v2] ppc4xx: Rename compactcenter to intip

[Stefan Roese]

Hi Dirk,

On Friday 21 August 2009 10:13:21 Dirk Eibach wrote:
> Signed-off-by: Dirk Eibach <eibach@gdsys.de>
> ---
> Changes since v1:
> - also changed config name
>
>  Makefile                        |   16 ++++++++--------
>  include/configs/compactcenter.h |    6 +++---
>  2 files changed, 11 insertions(+), 11 deletions(-)

I just noticed that when changing the config name, you also need to change 
this in MAKEALL and MAINTAINERS. And thinking further about it, you are now 
removing the target name "compactcenter", but you keep the files 
"compactcenter.h" and the board directory "board/gdsys/compactcenter". This 
seems inconsistent to me.

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de

[U-Boot] [PATCH v2] ppc4xx: Rename compactcenter to intip

[Stefan Roese]

Hi Dirk,

On Wednesday 26 August 2009 09:08:26 Stefan Roese wrote:
> > Signed-off-by: Dirk Eibach <eibach@gdsys.de>
> > ---
> > Changes since v1:
> > - also changed config name
> >
> >  Makefile                        |   16 ++++++++--------
> >  include/configs/compactcenter.h |    6 +++---
> >  2 files changed, 11 insertions(+), 11 deletions(-)
> 
> I just noticed that when changing the config name, you also need to change
> this in MAKEALL and MAINTAINERS. And thinking further about it, you are now
> removing the target name "compactcenter", but you keep the files
> "compactcenter.h" and the board directory "board/gdsys/compactcenter". This
> seems inconsistent to me.

Any news on this?
 
Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de