From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Tue, 8 Sep 2009 13:04:16 +0200 Subject: [U-Boot] PPC440GX: DDR ECC init time. In-Reply-To: <4AA62C6A.9020102@embedded-sol.com> References: <4CD35CD1F8085945B597F80EEC8942130348D9E7@exc01.bk.prodrive.nl> <200909081149.44534.sr@denx.de> <4AA62C6A.9020102@embedded-sol.com> Message-ID: <200909081304.16623.sr@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Felix, On Tuesday 08 September 2009 12:05:30 Felix Radensky wrote: > > Most likely historic reasons. I added Grant Erickson to Cc, IIRC he > > added/tested this ecc_init() code. Maybe he can shed some more light into > > this. > > > > But from looking at it, it seems to me that we should get rid of one of > > those routines. program_ecc_addr() seems more generic to me. Patches > > welcome. ;) > > OK, unless Grant objects I'll try to cook up a patch, most probably next > week. > I have 405EX and 460EX boards with ECC enabled soldered DDR2, so > I'll be able to test these cases. It would be great if someone could > test SPD case, > to see that I didn't break anything. Great. I'll test it on Katmai (440SPe DDR2 with ECC enabled). Thanks. Cheers, Stefan -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de