[U-Boot] [PATCH] tools/netconsole: make a bit more robust and use ncb when possible

[Mike Frysinger <vapier@gentoo.org>]

On Wednesday 09 September 2009 09:28:42 Wolfgang Denk wrote:
> Mike Frysinger wrote:
> > On Friday 09 January 2009 04:38:22 Mike Frysinger wrote:
> > > The netcat utility likes to exit when it receives an empty packet (as
> > > it thinks this means EOF).  This can easily occur when working with
> > > command line editing as this behavior will be triggered when using
> > > backspace.  Or with tabs and command line completion.  Since the local
> > > ncb util does not have this "feature" and it supports broadcast udp,
> > > default to using that rather than netcat.
> >
> > ping ... afaik, it should still apply fine
> 
> Maybe. But I still don't like the patch. Now, with the distance of a
> few months, I think it should be split into two parts:
> 
> 1) "make a bit more robust"
> 
> I agree that this is kind of a bug fix; I think it can go in.

np

> 2) "use ncb when possible"
> 
> Here I really dislike the implementation of "when possible", which
> makes silent and undocumented assumptions about from which directory
> the script has to be run. I guess the "when possible" would almost
> always turn out to be false, so we might omit the patch alltogether,
> especially since it's also documented in "doc/README.NetConsole".
> 
> If we add it, we should follow standard UNIX philosophy and assume
> that you set your PATH accordingly to reach the tools you want to use.

since ncb is compiled whenever netconsole is enabled, and people typically use 
this script with netconsole enabled, "when possible" tends to be line up 
fairly often.  also, the broadcast aspect is pretty useful.  i guess i could 
make it search PATH, but the idea was to have things "just work" rather than 
forcing people to install random utils into their PATH.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090909/90db57e6/attachment.pgp