[U-Boot] [PATCH v2 1/2] mkconfig: split the board make target to multiple config targets

Kumar Gala
2009-09-11T15:35:33Z

On Sep 11, 2009, at 10:20 AM, Scott Wood wrote:

> On Fri, Sep 11, 2009 at 10:07:46AM +0200, Wolfgang Denk wrote:
>> In message <1252466603-25103-1-git-send-email-Mingkai.hu@freescale.com
>> > you wrote:
>>> To simplify the top level makefile it useful to be able to parse
>>> the top level makefile target to multiple individual target, then
>>> put them to the config.h, leave the board config file to handle
>>> the different targets.
>
> [snip]
>
>> Arghhh... It seems this patch has not been well tested. Obviously
>> never ever ran a MAKEALL over all PPC boards. It causes tons of
>> messages like that:
>>
>> include/config.h:2:25: warning: missing whitespace after the macro
>> name
>>
>> This patch breaks building for a number of boards / configurations,
>
> Actually, I think the patch you quoted would not have had this
> problem --
> unlike the one you merged, it doesn't create #defines for all boards,
> only those which request it by passing -t to mkconfig.

I'm with Scott on this. Why not just have it be a new explicit option
to mkconfig?

- k