From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Mon, 14 Sep 2009 17:44:28 +0200 Subject: [U-Boot] [PATCH v4 2/2] mucmc52, uc101: delete ata@3a00 node, if no CF card is detected In-Reply-To: <4AAE6755.5060205@denx.de> References: <4AA755D4.1020207@denx.de> <200909141729.56736.sr@denx.de> <4AAE6755.5060205@denx.de> Message-ID: <200909141744.28922.sr@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Monday 14 September 2009 17:55:01 Heiko Schocher wrote: > >>> Incorrect multi-line parentheses: > >>> > >>> if (nodeoffset >= 0) { > >>> fdt_del_node(blob, nodeoffset); > >>> } else { > >>> printf("%s: cannot find %s node err:%s\n", > >>> __func__, nodename, fdt_strerror(nodeoffset)); > >>> } > >> > >> if (nodeoffset >= 0) > >> fdt_del_node(blob, nodeoffset); > >> else > >> printf("%s: cannot find %s node err:%s\n", > >> __func__, nodename, > >> fdt_strerror(nodeoffset)); > >> > >> Should be right, or? > > > > No. IIRC, then when one of the statements is a multi-line statement, both > > statements of the if/else struct should have the parentheses. > > I see only one statement in the if and the else case ... Yes, but it spans over multiple (2) lines. So it's a multi-line statement. At least that's how I understand the coding-style docs. Cheers, Stefan -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de