From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Thu, 17 Sep 2009 08:56:08 +0200
Subject: [U-Boot] [PATCH v4 3/4]: Define ffs/fls for all architectures
In-Reply-To: <20090917084521.4bfbb4e7@marrow.netinsight.se>
References: <20090824090605.37715546@marrow.netinsight.se>
	<200909162119.03918.sr@denx.de>
	<20090917084521.4bfbb4e7@marrow.netinsight.se>
Message-ID: <200909170856.08285.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Thursday 17 September 2009 08:45:21 Simon Kagstrom wrote:
> > One way to solve this would be something like this:
> >
> > include/asm-ppc/bitops.h:
> > @@ -230,6 +231,7 @@ extern __inline__ int ffs(int x)
> >  {
> >  	return __ilog2(x & -x) + 1;
> >  }
> > +#define PLATFORM_FFS
> >
> > include/linux/bitops.h:
> > +#ifndef PLATFORM_FFS
> > +# define ffs generic_ffs
> > +#endif
> 
> Yes, the patch should have contained something like that. Well, we'll
> have to cook up a fix for this then. Sorry about that again.

Simon, could you do this please?

And btw:

#ifndef __set_bit
# define __set_bit generic_set_bit
#endif

looks fishy too. Please fix this one as well.

Thanks.
 
Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de