From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/5] mpc83xx: mpc8360emds: Use RGMII mode, add workarounds for rev. 2.1 CPUs
Date: Sat, 19 Sep 2009 03:29:17 +0400 [thread overview]
Message-ID: <20090918232917.GA23055@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <20090918174045.70d9d3da.kim.phillips@freescale.com>
On Fri, Sep 18, 2009 at 05:40:45PM -0500, Kim Phillips wrote:
> On Wed, 16 Sep 2009 23:21:59 +0400
> Anton Vorontsov <avorontsov@ru.mvista.com> wrote:
>
> > This patch fixes various ethernet issues with gigabit links handling
> > in U-Boot. The workarounds originally implemented by Kim Phillips for
> > Linux kernel.
> >
> > Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> > ---
>
> sorry, can't accept - this breaks r1.1 based boards:
Oops. Thanks a lot for testing.
I think I know why it breaks, we should use RGMII_ID for < 2.1
revs (at least that's what we have in Linux by default). I don't
have r1.1 CPUs, can you please try this patch on top of the
current patch set?
If it'll work, I'll repost a fixed version of this patch.
diff --git a/include/configs/MPC8360EMDS.h b/include/configs/MPC8360EMDS.h
index dab0173..62cf13b 100644
--- a/include/configs/MPC8360EMDS.h
+++ b/include/configs/MPC8360EMDS.h
@@ -399,7 +399,7 @@
#define CONFIG_SYS_UEC1_TX_CLK QE_CLK9
#define CONFIG_SYS_UEC1_ETH_TYPE GIGA_ETH
#define CONFIG_SYS_UEC1_PHY_ADDR 0
-#define CONFIG_SYS_UEC1_INTERFACE_MODE ENET_1000_RGMII
+#define CONFIG_SYS_UEC1_INTERFACE_MODE ENET_1000_RGMII_ID
#endif
#define CONFIG_UEC_ETH2 /* GETH2 */
@@ -410,7 +410,7 @@
#define CONFIG_SYS_UEC2_TX_CLK QE_CLK4
#define CONFIG_SYS_UEC2_ETH_TYPE GIGA_ETH
#define CONFIG_SYS_UEC2_PHY_ADDR 1
-#define CONFIG_SYS_UEC2_INTERFACE_MODE ENET_1000_RGMII
+#define CONFIG_SYS_UEC2_INTERFACE_MODE ENET_1000_RGMII_ID
#endif
/*
next prev parent reply other threads:[~2009-09-18 23:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-16 19:21 [U-Boot] [PATCH 4/5] mpc83xx: mpc8360emds: Use RGMII mode, add workarounds for rev. 2.1 CPUs Anton Vorontsov
2009-09-18 22:40 ` Kim Phillips
2009-09-18 23:29 ` Anton Vorontsov [this message]
2009-09-25 23:32 ` Kim Phillips
2009-09-26 0:33 ` Ben Warren
2009-09-26 0:47 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090918232917.GA23055@oksana.dev.rtsoft.ru \
--to=avorontsov@ru.mvista.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox