[U-Boot] MPC83xx and uec

[Anton Vorontsov <avorontsov@ru.mvista.com>]

On Tue, Sep 22, 2009 at 04:03:16PM +0200, Joakim Tjernlund wrote:
[...]
> > > > Also
> > > >  drivers/qe/uec.h:int uec_initialize(bd_t *bis, uec_info_t *uec_info);
> > > >  include/netdev.h:int uec_initialize(int index);
> > > > different prototypes for the same function.
> > >
> > > BTW, I am looking for a way to swap the order of ethernet interfaces:
> > > static uec_info_t uec_info[] = {
> > > #ifdef CONFIG_UEC_ETH1
> > >    STD_UEC_INFO(1),   /* UEC1 */
> > > #endif
> > > #ifdef CONFIG_UEC_ETH2
> > >    STD_UEC_INFO(2),   /* UEC2 */
> > > #endif
> > > #ifdef CONFIG_UEC_ETH3
> > >    STD_UEC_INFO(3),   /* UEC3 */
> > > #endif
> > > };
> >
> > Works for me:
> >
> > http://lists.denx.de/pipermail/u-boot/2009-September/060821.html
> 
> Right, but I don't consider a include as this:
>   +#include "../../../drivers/qe/uec.h"
> as the correct way of getting of required data types and macros.
> Consider that uec_initialize() is exported by netdev.h (although with the
> wrong prototype ATM). As far as I can tell, I should only have to include
> netdev.h to get the required types and macros.

Not sure if having all-in-one netdev header is a good idea.
It might be a good idea to move uec.h to "include/" though.

-- 
Anton Vorontsov
email: cbouatmailru at gmail.com
irc://irc.freenode.net/bd2